Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getAdminLink 3rd argument #148

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Fix getAdminLink 3rd argument #148

merged 1 commit into from
Oct 28, 2021

Conversation

atomiix
Copy link
Contributor

@atomiix atomiix commented Oct 26, 2021

Questions Answers
Description? The method Link::getAdminLink() expect an array as 3rd argument, false was given. This PR aims to fix that.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? CI should be green

ghost
ghost approved these changes Oct 27, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix php stan error for : #145

@atomiix atomiix mentioned this pull request Oct 27, 2021
Merged
@Progi1984 Progi1984 added this to the 1.3.0 milestone Oct 28, 2021
@Progi1984 Progi1984 merged commit 83ff14b into PrestaShop:dev Oct 28, 2021
@Progi1984
Copy link
Member

Thanks @atomiix

@atomiix atomiix deleted the fix/ci branch October 28, 2021 08:20
@PululuK PululuK mentioned this pull request Oct 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@PululuK PululuK PululuK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@atomiix @Progi1984 @PululuK