JSX: Add support for plain text inside tags #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golmote
force-pushed
the
jsx-plain-text-2
branch
from
2918155
to
468bbee
Compare
|
LGTM. Nice work! |
|
Me too! Thank you! |
|
Looks good, quite neat code! Thanks @Golmote ! Glad to see my approach could help. Just one comment: could you make jsx text a special token type (like jsx-text) rather than plain text? So that we could differentiate it from other text like variable definition, then they can have different colors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt at fixing #1294, based on a great idea from @supnate (#1342 (comment)).
It uses a new hook to post-process the tokenized code and drop tokens that were wrongly highlighted.
Unlike #1304, it should provide full support for plain text, here, since we keep count of the opening tags and braces.
Please give me your thoughts about this. @m-allanson, @LeaVerou, @mAAdhaTTah, @vkbansal