JS: Added support for numeric separators #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasbynens
approved these changes
May 18, 2019
|
@mathiasbynens Thank you for reviewing! |
|
@RunDevelopment Thanks for the quick patch! There’s no rush, but what’s the general process for releasing a new |
|
There is no fixed release schedule. A new version usually gets releases once enough changes have been made. |
mathiasbynens
added a commit
to v8/v8.dev
that referenced
this pull request
May 19, 2019
This applies @RunDevelopment’s patch from PrismJS/prism#1895. It can be removed once a new prism-js release is published to npm. Closes #182.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1893.
The
numberpattern is quite a bit longer because of this change, so any ideas on how we could simplify this are more than welcome.Spec changes.