Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript numeric separators #1893

Closed
mathiasbynens opened this issue May 16, 2019 · 1 comment · Fixed by #1895
Closed

JavaScript numeric separators #1893

mathiasbynens opened this issue May 16, 2019 · 1 comment · Fixed by #1895
Labels
enhancement language-definitions

Comments

@mathiasbynens
Copy link
Contributor

mathiasbynens commented May 16, 2019 •
edited
Loading

Information

  • Language: JavaScript
  • Plugins: none

Does the problem still occur in the latest version of Prism? You can check using the test page or get the latest version at the download page.

Yes

Description
A clear and concise description of what is being highlighted incorrectly and how it should be highlighted instead. Add screenshots to illustrate the problem.

The use of numeric separators causes numeric literals to be highlighted incorrectly.

The code being highlighted incorrectly. 
1_000_000_000_000
    1_019_436_871.42

Screenshot from https://v8.dev/blog/v8-release-75#numeric-separators:
@RunDevelopment RunDevelopment mentioned this issue May 17, 2019
Merged
@RunDevelopment
Copy link
Member

Thank you for reporting this issue!

@mathiasbynens mathiasbynens mentioned this issue May 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement language-definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JS: Added support for numeric separators RunDevelopment/prism
2 participants
@mathiasbynens @RunDevelopment