Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoHotkey: missing definitions #2400

Merged
merged 3 commits into from May 25, 2020
Merged

AutoHotkey: missing definitions #2400

merged 3 commits into from May 25, 2020

Conversation

@joedf
Copy link
Contributor

@joedf joedf commented May 23, 2020

Missing definitions

Thanks to ahk users BoBo and Xtra for reporting these.
https://www.autohotkey.com/boards/viewtopic.php?f=3&t=76304

constant

A_FileEncoding
A_Is64bitOS
A_PriorKey
A_PtrSize
A_RegView
A_ScreenDPI
A_ScriptHwnd

keyword

Throw
Try
Catch
Finally
Until
ahk_exe

builtin

LTrim() - was incorrect
RTrim()
StrReplace()
ComObjActive()
ComObjArray()
ComObjConnect()
ComObjCreate()
ComObjError()
ComObjFlags()
ComObjGet()
ComObjQuery()
ComObjType()
ComObjValue()

important

#DerefChar
#If
#IfTimeout
#InputLevel
#MenuMaskKey
#Warn

selector

SetRegView

# Missing definitions

constant
================
A_FileEncoding
A_Is64bitOS
A_PriorKey
A_PtrSize
A_RegView
A_ScreenDPI
A_ScriptHwnd

keyword
====================
Throw
Try
Catch
Finally
Until
ahk_exe

builtin
====================
LTrim() - was incorrect
RTrim()
StrReplace()
ComObjActive()
ComObjArray()
ComObjConnect()
ComObjCreate()
ComObjError()
ComObjFlags()
ComObjGet()
ComObjQuery()
ComObjType()
ComObjValue()

important
====================
#DerefChar
#If
#IfTimeout
#InputLevel
#MenuMaskKey
#Warn

selector
===================
SetRegView
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented May 23, 2020

Thank you for making this PR @joedf!

Before we can merge this you need to rebuild Prism by running npx gulp.
Also, please add your changes to the corresponding test files. Here's how you edit test files.

@joedf
Copy link
Contributor Author

@joedf joedf commented May 25, 2020

Done! 👍

@RunDevelopment RunDevelopment merged commit 4fe0367 into PrismJS:master May 25, 2020
1 check passed
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented May 25, 2020

Thank you for contributing @joedf!

quentinvernot added a commit to TankerHQ/prismjs that referenced this issue Sep 11, 2020
This adds a lot of missing keywords, builtins, constants, and other definitions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants