Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for Dart classes & generics #2810

Merged
merged 1 commit into from Mar 17, 2021

Conversation

@brianegan
Copy link
Contributor

@brianegan brianegan commented Mar 17, 2021

  • No longer depend on keywords such as new or extends
  • Detect PascalCase class names instead
  • Support generic parameters as well
  • Properly highlights class constructors
  • Added tests
Before After
Screenshot from 2021-03-17 14-37-42 Screenshot from 2021-03-17 14-39-15
Screenshot from 2021-03-17 14-38-05 Screenshot from 2021-03-17 14-39-06
@github-actions
Copy link

@github-actions github-actions bot commented Mar 17, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +228 B (+46.3%).

file master pull size diff % diff
components/prism-dart.min.js 492 B 720 B +228 B +46.3%

Generated by 🚫 dangerJS against 7b42bc5

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Thank you for the PR @brianegan!

One small nit and then gtg.

components/prism-dart.js Show resolved Hide resolved
@RunDevelopment RunDevelopment merged commit d0bcd07 into PrismJS:master Mar 17, 2021
8 checks passed
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Mar 17, 2021

Thank you for contributing @brianegan!

@brianegan
Copy link
Contributor Author

@brianegan brianegan commented Mar 17, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants