-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use terser #3407
Use terser #3407
Conversation
JS File Size Changes (gzipped)A total of 108 files have changed, with a combined diff of +288 B (+0.3%).
|
I had to disable unsafe transformations again because of a bug in the v8 version shipped in NodeJS 10.x. I even reported and helped fix this bug in terser a while ago, but it seems that there was a regression. It's a shame, but it's not worth the hassle now. Since this is a NodeJS 10.x specific bug, we might as well enable the transformation after dropping support for that version of Node. |
This PR replaces UglifyJS 3 with Terser (5.x).
Since we want to transition to ES6 in v2, we'll need a minifier that supports ES6. We currently use UglifyJS 3, but that is a pure ES5 minifier. Since transpiling our code into ES5 would add complexity and result in worse file sizes, I think the easiest solution is to just minify our ES6(+?) code.