Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Burn after reading alert message apostrophes are escaped #558

Closed
calvinbui opened this issue Jan 11, 2020 · 1 comment · Fixed by #560
Closed

Burn after reading alert message apostrophes are escaped #558

calvinbui opened this issue Jan 11, 2020 · 1 comment · Fixed by #560
Labels
duplicate

Comments

@calvinbui
Copy link

Steps to reproduce

  1. Create a new Burn After Reading paste
  2. Read the alert

What happens

The apostrophes in Don't and can't appear as '

image

What should happen

The words Don't and can't

image

Additional information

Basic information

Server address:

Server OS:

Webserver:

Browser:

  • Chromium 79
  • Firefox 72

PrivateBin version: 1.3.2

I can reproduce this issue on https://privatebin.net: Yes
@calvinbui calvinbui changed the title Burn after reading, alert message apostrophe is escaped Burn after reading alert message apostrophes are escaped Jan 11, 2020
@elrido
Copy link
Contributor

elrido commented Jan 12, 2020

same issue as #557

@elrido elrido closed this as completed Jan 12, 2020
@rugk rugk mentioned this issue Jan 13, 2020
Closed
rugk added a commit that referenced this issue Jan 13, 2020
@rugk
Do not double-encode HTML in i18n
01414e4 
This issue got introduced in 4bf7f86 due to double

Fixes #557
Fixes #558

Also _inverted_ the logic/variable name for containsNoLinks to
the more logical one "containsLinks" to avoid too many negations.

Also verified that the attachment name is stil properly displayed
when you clone a paste.
@rugk rugk mentioned this issue Jan 13, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not double-encode HTML in i18n PrivateBin/PrivateBin
2 participants
@elrido @calvinbui