Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronization #13

Open
ProGTX opened this issue Oct 11, 2015 · 3 comments
Open

Synchronization #13

ProGTX opened this issue Oct 11, 2015 · 3 comments
Labels
bug enhancement
Milestone
Update to final 1...

Comments

@ProGTX
Copy link
Owner

ProGTX commented Oct 11, 2015

Already mentioned in #6

Parts to implement per §2.5.5:

  • ⚠️ Buffer destruction
  • ✅ Accessor construction
  • ✅ Command group enqueue
  • ⚠️ Interaction with OpenCL synchronization operations
    • I'm not sure what this is supposed to entail with regard to buffer and image. Maybe mutex?
    • ⚠️ handler_event from queue.
  • ✅ Queue destruction
  • ⚠️ Context destruction
    • Not high priority, problems with copies and moves.
  • ⚠️ SYCL event objects
@ProGTX ProGTX mentioned this issue Oct 11, 2015
Closed
@ProGTX ProGTX mentioned this issue Oct 25, 2015
Closed
@ProGTX
Copy link
Owner Author

ProGTX commented Oct 25, 2015

"Command group enqueue", or intra-queue synchronization, was done alongside #14.

@ProGTX
Copy link
Owner Author

ProGTX commented Oct 26, 2015

Host accessors synchronized with synchronizer class (see #1).

@ProGTX
Copy link
Owner Author

ProGTX commented Oct 30, 2015

Forgot to take into account that host accessors block the queue for their whole lifetime, and just synchronization on construction isn't enough. Fixed in d25b7f5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
Update to final 1.2 specification
Development

No branches or pull requests
1 participant
@ProGTX