Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update com.google.Chrome.plist #633

Merged

Conversation

BigMacAdmin
Copy link
Contributor

Adding 4 new "privacy sandbox ad controls" for Google Chrome

https://chromeenterprise.google/policies/#PrivacySandbox

Adding 4 new "privacy sandbox ad controls" for Google Chrome

https://chromeenterprise.google/policies/#PrivacySandbox
@kevinmcox kevinmcox added the 🛠️ update manifest Update existing manifest label Sep 27, 2023
@relgit
Copy link
Member

relgit commented Sep 28, 2023

Thank for the submission; the changes look good to me. Now we just need to have pfm_version bumped, pfm_last_modified updated, the new keys added to pfm_segments, and we're good to go.

@BigMacAdmin
Copy link
Contributor Author

@relgit
Is the pfm_segments array the deciding factor that determines which tab a configuration key is displayed under?
If so, and additionally: I've added 4 new keys for the Google Chrome profile related to ad privacy. Which tab would these be appropriate for? Misc. or maybe Content Settings? Or does this justify an entirely new tab for "Privacy" or "Ad Tracking"?

@relgit
Copy link
Member

relgit commented Oct 2, 2023

Yes, pfm_segments determines that tab that subkeys appear under.

I can see that Google chose to group these new four subkey on their own and not as part of the Misc. group, and honestly Misc. is already very crowded, so yes, lets create a new Privacy Sandbox group. To create a new group you'll need to also amend the PFC_SegmentedControl_0 subkey.

`pfm_last_modified` updated
`pfm_version` bumped

Added new keys to `pfm_segments`
Added new "Privacy Sandbox" group in the `PFC_SegmentedControl_0` subkey
@BigMacAdmin
Copy link
Contributor Author

There must be something I'm missing, I've followed your instructions but I cannot seem to get a new "Privacy Sandbox" group created.

The new keys still show in the "Other" section within iMazing Profile Editor.

Copy link
Member

@relgit relgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's OK. I'm assuming this was tested on iMazing Profile Editor, which has a grouping override on the Chrome manifest. To show the actual grouping that's in the manifest, you can untick Process custom manifests for optimal display in iMazing Profile Editor (recommended) in the app settings.
The override will be updated in the next release to fall in line with this pull request.

Now, the grouping changes look good, but have a look please at my comments for two small issues that require addressing.

Thanks!

Fixed indentation and lost </dict> closing
@relgit relgit merged commit 029b34d into ProfileManifests:master Oct 10, 2023
apizz pushed a commit that referenced this pull request Nov 25, 2023
* Update com.google.Chrome.plist

Adding 4 new "privacy sandbox ad controls" for Google Chrome

https://chromeenterprise.google/policies/#PrivacySandbox

* Update com.google.Chrome.plist

`pfm_last_modified` updated
`pfm_version` bumped

Added new keys to `pfm_segments`
Added new "Privacy Sandbox" group in the `PFC_SegmentedControl_0` subkey

* Update com.google.Chrome.plist

Fixed indentation and lost </dict> closing

* Google Chrome manifest passed through plutil

---------

Co-authored-by: Ari Leviatan <relgit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ update manifest Update existing manifest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants