Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change zipCode to zip #120

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Change zipCode to zip #120

merged 3 commits into from
Mar 9, 2022

Conversation

teakopp
Copy link
Member

@teakopp teakopp commented Mar 5, 2022 •
edited
Loading

  • Changes zipcode to zip to match var being passed in req.body

@teakopp teakopp requested a review from a team as a code owner March 5, 2022 20:47
@teakopp teakopp changed the title change zipCode to zip Change zipCode to zip Mar 5, 2022
@teakopp teakopp mentioned this pull request Mar 5, 2022
Closed
JamesMGreene
JamesMGreene previously approved these changes Mar 5, 2022
View reviewed changes
Copy link
Contributor

@JamesMGreene JamesMGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine but left an alternative suggestion.

server/routes/api/lob.js Show resolved Hide resolved
@JamesMGreene JamesMGreene dismissed stale reviews from themself via f47d8c6 March 9, 2022 17:00
@JamesMGreene JamesMGreene merged commit d067938 into main Mar 9, 2022
@JamesMGreene JamesMGreene deleted the teakopp-fix-createAddress branch March 9, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesMGreene JamesMGreene JamesMGreene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teakopp @JamesMGreene