Include real coordinates in debug geojson mode #1966
Conversation
|
@karenzshea Can you squash these commits and update the commit message to be the same as the message for this PR? Other than that, looks good to go! |
karenzshea
force-pushed
the
readymade-debug
branch
from
11b4aeb
to
b413b44
Compare
| { | ||
| nodes_input_stream.read((char *)¤t_node, sizeof(extractor::QueryNode)); | ||
| node_lookup_map[current_node.node_id] = util::FixedPointCoordinate(current_node.lat, current_node.lon); | ||
| } nodes_input_stream.close(); |
There was a problem hiding this comment.
Run clang-format (similat to gofmt for example) that re-formats against our .clang-format specs.
karenzshea
force-pushed
the
readymade-debug
branch
from
b413b44
to
8253552
Compare
| @@ -4,6 +4,8 @@ | |||
| #include "contractor/contractor_config.hpp" | |||
| #include "extractor/query_node.hpp" | |||
| #include "osrm/coordinate.hpp" | |||
| #include <ios> | |||
karenzshea
force-pushed
the
readymade-debug
branch
from
8253552
to
7398bed
Compare
|
why did we just merge more undefined behaviour into the codebase? |
|
This is code that is only used for debug purposes. It's not even compiled in production. |
|
Hi I've just posted an issue related to this (issue #2024) and am hoping that flagging it here is ok. This thread seems to contain the people who have touched the debug geoJSON mode code so I thought flagging it here would make sense (but I've written a separate comment so as not to clog up this pull request). @TheMarex , @danpat, @daniel-j-h in particular... I'm getting a blank geoJSON file out when running osrm-prepare with the option --debug-geometry. The option is there and --debug-turns is working fine for me with osrm-extract. I'd would really appreciate any help if you have time to check out issue #2024. Thanks! Mike |
#1956
For building with the
DEBUG_GEOMETRY=ON, previously the output geojson only has OSM node ids in the coordinates field, this uses the osrm.nodes file to lookup real lon/lat coordinates and write them.@danpat @TheMarex