Set type of trivial intersections where classes change to Suppressed #4816
Conversation
features/car/classes.feature
Outdated
| @@ -119,6 +119,25 @@ Feature: Car - Mode flag | |||
| | from | to | route | turns | classes | | |||
| | a | d | ab,bc,cd,cd | depart,new name right,new name left,arrive | [()],[(tunnel)],[()],[()] | | |||
|
|
|||
| Scenario: Car - We tag tunnel with a class | |||
| Background: | |||
There was a problem hiding this comment.
Should we change the name of the scenario above? Does it matter if we keep the same name for both scenarios?
There was a problem hiding this comment.
👍 change to Car - We tag classes without intersections
oxidase
force-pushed
the
fix/changed_classes
branch
2 times, most recently
from
019dbce
to
21a079f
Compare
|
Looks good to me! 👍 |
oxidase
force-pushed
the
fix/changed_classes
branch
from
21a079f
to
6ff2828
Compare
There was a problem hiding this comment.
Looks good to me. The original reason why we did not announce there, was that some people were worried about the impact on guidance. To be safe I would compar the instruction distribution to master and look how many new suppressed instruction we introduce. Maybe go as far and compare the number of Continue instructions for a number of random routes.
|
@TheMarex in SF-area there are 147 new suppressed instructions https://gist.github.com/oxidase/9a78e927b78af1d796639e8dbdaa9acd mainly tunnels and restricted roads. |
... instead of NoTurn
oxidase
force-pushed
the
fix/changed_classes
branch
from
6ff2828
to
46497f8
Compare
Issue
In some cases like tunnels or bridges way classes may change at trivial intersections of degree two.
Maneuvers at such intersections have turn types
NoTurnand intersections will be removed from response intersections arrays.Tasklist
Requirements / Relations
#4812