Fix bindings compilation on latest Node #6416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,7 @@ | |||
| "@mapbox/node-pre-gyp": "^1.0.9", | |||
| "cheap-ruler": "^3.0.2", | |||
| "mkdirp": "^0.5.6", | |||
| "nan": "^2.16.0", | |||
| "nan": "^2.17.0", | |||
There was a problem hiding this comment.
This version seems to contain fixes for this problem nodejs/nan@7f9ceb8#diff-03fb352255b722199246b26ee44cbe9528ab45c581f294c0e8a2fb4ad7ef6ba8L55
There was a problem hiding this comment.
Not sure what is the root cause, may be Node 18.11.0 which was released recently https://nodejs.org/en/blog/release/v18.11.0/ (and latest seems to point to it)
SiarheiFedartsou
force-pushed
the
sf-node-latest-fix
branch
from
4f73eae
to
b707d00
Compare
6 tasks
mjjbell
approved these changes
Oct 18, 2022
mattwigway
pushed a commit
to mattwigway/osrm-backend
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?