Commits on Oct 23, 2022

1. Fix adding traffic signal penalties during compression …

   Weight and duration penalties are flipped in the lambda function
   that applies penalties from traffic signals.
   
   Duration is in deciseconds, whilst weight is multipled by
   10^weight_precision, with weight_precision being 1 by default.
   
   Therefore, for default routability profile, the penalties end up
   being the same, hence why no tests picked this up.
   
   If distance weight is used however, it will incorrectly apply an
   additional penalty to the weight, and not add the traffic signal
   delay to the duration in the routing graph.
   
   To confuse things further, in some API responses the values are
   correct because they use geometry data instead, but it's still
   possible that a sub-optimal route was selected.
   
   However, given the distance weight is in meters, and the additional
   penalty per traffic light would be 20, it's unlikely this would
   have changed the routing results.
   
   In any case, we correct the function to apply the arguments correctly.

   

   mjjbell committed Oct 23, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 932bdb6
   • Browse repository at this point

   Copy the full SHA

   932bdb6 View commit details

   Browse the repository at this point in the history