-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use C++20 #6877
Use C++20 #6877
Changes from all commits
9703b78
fe9464b
91e8c20
39e814a
8bf2d9e
f4b5004
f1f2cb2
4efea7c
d491b63
29b2640
a7b4559
c865cc5
f2c1305
69c2231
18d82d3
08438be
5974436
bbf2eb4
4da40c8
be779c4
f3a9533
8baf4b1
0f99a37
ba97914
f57fcf2
f61e264
f8a061b
41f90ab
e03c943
71e4b1a
4f9ddba
3094523
7468f2f
7234fcd
91e3943
5408449
8f7d492
90a1f18
8b13365
e79fb0d
fbe5f0f
f0ac2e3
923f8a8
400732a
1c3c56b
541d4fa
2fa4506
99aa9cd
405e7f2
fa99143
783fc23
c7065ef
33d50de
ca6f3d7
419b73b
53a251c
836eb8c
e105c02
969e4cd
6c5249d
e9ad8ba
0449868
f368348
945e4d2
9927826
d59e07a
2844267
e5a1a44
0768998
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -396,7 +396,36 @@ jobs: | |
elif [[ "${RUNNER_OS}" == "macOS" ]]; then | ||
echo "JOBS=$((`sysctl -n hw.ncpu` + 1))" >> $GITHUB_ENV | ||
fi | ||
# See: https://github.com/actions/toolkit/issues/946#issuecomment-1590016041 | ||
# We need it to be able to access system folders while restoring cached Boost below | ||
- name: Give tar root ownership | ||
if: runner.os == 'Linux' && matrix.ENABLE_CONAN != 'ON' | ||
run: sudo chown root /bin/tar && sudo chmod u+s /bin/tar | ||
- name: Cache Boost | ||
if: runner.os == 'Linux' && matrix.ENABLE_CONAN != 'ON' | ||
id: cache-boost | ||
uses: actions/cache@v4 | ||
with: | ||
path: | | ||
/usr/local/include/boost | ||
/usr/local/lib/libboost* | ||
key: v1-boost-${{ runner.os }}-${{ runner.arch }}-${{ matrix.runs-on }} | ||
restore-keys: | | ||
v1-boost-${{ runner.os }}-${{ runner.arch }}-${{ matrix.runs-on }} | ||
|
||
- name: Install Boost | ||
if: steps.cache-boost.outputs.cache-hit != 'true' && runner.os == 'Linux' && matrix.ENABLE_CONAN != 'ON' | ||
run: | | ||
BOOST_VERSION="1.85.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There were problems with Boost from apt on Ubuntu 22.04, so I propose to install it manually for the time being. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would a switch to 24.04 make this easier? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, with a switch to 24.04 I had another challenge: sol2 is not compiling with newest clang we would have to switch to on 24.04. There is already fix in LLVM, so I believe it is just easier to wait for a while until this fix will come to GitHub Actions runner image for 24.04 and switch. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The fix is only going to make it to clang 19, unfortunately. |
||
BOOST_VERSION_UNDERSCORE="${BOOST_VERSION//./_}" | ||
wget -q https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VERSION}/source/boost_${BOOST_VERSION_UNDERSCORE}.tar.gz | ||
tar xzf boost_${BOOST_VERSION_UNDERSCORE}.tar.gz | ||
cd boost_${BOOST_VERSION_UNDERSCORE} | ||
sudo ./bootstrap.sh | ||
sudo ./b2 install | ||
cd .. | ||
sudo rm -rf boost_${BOOST_VERSION_UNDERSCORE}* | ||
|
||
- name: Install dev dependencies | ||
run: | | ||
python3 -m pip install "conan<2.0.0" || python3 -m pip install "conan<2.0.0" --break-system-packages | ||
|
@@ -417,7 +446,7 @@ jobs: | |
# Linux dev packages | ||
if [ "${ENABLE_CONAN}" != "ON" ]; then | ||
sudo apt-get update -y | ||
sudo apt-get install -y libbz2-dev libxml2-dev libzip-dev liblua5.2-dev libboost-all-dev | ||
sudo apt-get install -y libbz2-dev libxml2-dev libzip-dev liblua5.2-dev | ||
if [[ "${CCOMPILER}" != clang-* ]]; then | ||
sudo apt-get install -y ${CXXCOMPILER} | ||
fi | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a ticket into the backlog to fix these warnings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, #6902