Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean SendGrid Inbound Parse data #78

Open
gmittal opened this issue Jun 21, 2017 · 4 comments
Open

Clean SendGrid Inbound Parse data #78

gmittal opened this issue Jun 21, 2017 · 4 comments
Assignees
Labels

Comments

@gmittal
Copy link
Member

gmittal commented Jun 21, 2017

Sometimes we get traces of past emails attached to email messages.

@gmittal gmittal added the bug label Jun 21, 2017
@gmittal gmittal self-assigned this Jun 21, 2017
@ankitr ankitr modified the milestone: MVP Jul 27, 2017
@gmittal
Copy link
Member Author

gmittal commented Jul 28, 2017

Turns out that we're already using the standard library for inbound emailing parsing: https://github.com/github/email_reply_parser

I guess there are just some cases which can't be filtered out. Given that it's not a user-facing issue and it's only a volunteer thing, perhaps we could skip it?

cc: @ankitr

@ankitr
Copy link
Member

ankitr commented Jul 28, 2017

hm… i think it's fine too move this off mvp but i think we shouldn't consider the volunteer experience lower priority than the user experience. let's still look at this once we're shipped.

@ankitr ankitr removed this from the MVP milestone Jul 28, 2017
@gmittal
Copy link
Member Author

gmittal commented Aug 5, 2017

Seems as though the SendGrid npm module has changed significantly since Summer 2016 (latest version is 5.x and we're on 1.9.2). Seems as though they've added better support for Inbound Parse.

@johnguibas @xSmithereens: Can one of you experiment around with the new SendGrid npm module? It'll require some slight modifications to our copilot-communications package.

@gmittal gmittal changed the title Inbound email parse error Clean SendGrid Inbound Parse data Aug 5, 2017
@gmittal
Copy link
Member Author

gmittal commented Aug 6, 2017

This is a slight privacy issue because the unfiltered email may leak the user's signature, revealing sensitive information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants