Added creeper charging functionality to Lightning. #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Additions * Adds a check to ensure an entity is an instance of LivingEntity before casting in `PKListener`.
## Additions * Added EarthPillars. * Added `FireManipulation` and Combo permissions to plugin.yml. ## Fixes * Fixed FireWheel going over air. * Fixed AvatarState sound causing AvatarState not to work. * Fixed EarthSmash values being incorrect. * Fixed paralyzing abilities canceling the sneak event if the player was sneaking. ## Misc. Changes * Changed instructions in /bending help <ability> to ChatColor.WHITE. * Changed /bending help earth message to match others. * Improved check for exhaustion in move event. * Changed CoreAbility#getDescription() to pull combos from the lang config as well.
## Removals * Removes redundant checks in `PKListener`.
## Misc. Changes - Moves methods to their respective passive classes. - Renames Hydrosink,java to HydroSink.java ## Removals - Removes WaterPassive.java - Removes AirPassive.java
## Changes
* Reduces combo cleanup delay to one minute.
> * https://trello.com/c/NKnawxvA/730-combo-times
## Removals * Removes double if statement in `BendingPlayer`.
## Additions * Adds `isBender` to `BendingPlayer`.
## Additions * Added OFFHAND_TRIGGER to ClickType * Added IceBlast and IceSpike blast to collisions * Added ElementalAbility#getEarthbendableBlocks(), returns String list from config ## Fixes * Fixed PhaseChange not working on blocks placed over already melted blocks * Fixed IceBlast going on cooldown after sneaking after selecting a block * Fixed Paralyze going indefinitely when it has a cooldown of 0 * Fixed FireShield blocking arrows * Fixed Surge making TempBlocks revert * Fixed WaterArms making TempBlocks revert * Fixed FireSpin and FireKick not expanding to full size when hitting an entity * Fixed aiming bugs with WaterArms Spear * Fixed WaterManipulation and EarthBlast redirection not working when clicking on the ability * Fixed TempArmor issue where players could remove their helmet ## Removals * Removed unnecessary SuppressWarnings for deprecation in various classes ## Misc. Changes * Improved IceSpike blast animation * Improved code in ProjectKorra.java * Improved FireShield animation
## Fixes * Fixes `BendingPlayer#addCooldown()` adding cooldowns even if their time is set to an invalid number. * Prevents the PlayerCooldownChangeEvent from being fired on an invalid case.
🥇 👍 ## Additions * Added #getBlockFaceFromValue(int xyz, double value) to GeneralMethods.java * Added required variable to ComboAbilityInfo, Set of CoreAbility a Player must have active to use corresponding ComboAbility * Added PassiveAbility#isProgressable(), checks for if the ability uses its progress() method * Added IRON_TRAPDOOR to FerroControl functionality ## Fixes * Fixed and improved AirBlast functions with some mechanisms ## Removals * Removed useless code from GeneralMethods#getTargetedEntity() ## Misc. Changes * Changed passive classes to be more functional than previously * Changed canBendPassive and canUsePassive to have CoreAbility param instead of Element * Changed PassiveAbility#isInstantiable() to be a check if the ability must be activated by the player, not if it uses the constructor * Improved CoreAbility#progressAll() * Improved AirAgility and ChiAgility * Tweaked EarthPillars config
* Added Dynamic Sourcing config option
* Removed SpiritPlayer checks in BendingPlayer#canBind(CoreAbility ability)
* Due to recent changes to PK Spirits, this isn't needed anymore
## Fixes * Fixed Earth tunnel so that it will work through tall grass and other transparent blocks.
## Fixes * Fixed spelling error in ConfigManager.java
## Addition * Added a getter for the player object stored in bending player. Object was there, just not accessible. adds: getPlayer() method
• Added a "Sticky" feature to tremorsense (passive).
• Now when an earthbender moves onto a block they can't bend, the light will remain on the last bendable block
• After they go out of range (3 blocks; configurable), then the light goes out. Change to 0 to disable.
• Fixed WarrierStance NPE (from #830)
• Fixed being able to remove the EarthArmor armor items from their slots
• Fixed DensityShift softening your landing while you are an Airbender (and with optimizations to the if statements)
AcrobatStance NullPointerException * Caused by players disconnecting while having AcrobatStance active * Fixed by adding null check on bPlayer > * https://trello.com/c/wYVhu6IG/894-error-on-wip Bloodbending ConcurrentModificationException * Caused by players unintentionally (or intentionally!) trying to bloodbend a non-LivingEntity * Fixed by using an Iterator to remove the non-LivingEntity from the entities ArrayList > * https://trello.com/c/58OTgYW7/896-another-another-error-on-wip
## Additions * Adds duration values to AirShield, AirSpout, and Tornado. ## Fixes * Fixes spelling and grammar errors in ConfigManager. * Fixes incorrect path for HydroSink.java in ConfigManager.
## Fixes * Fixes some minor grammar issues within descriptions/texts. ## Misc. Changes * Changes death messages that say `experienced kinetic damage` to `experienced a fatal collision`.
## Misc. Changes
* Changes AirShield to permit AirSwipe to pass through it.
> * https://trello.com/c/B4CdAfNV/876-airshield-blocks-airswipe
• Fixed the passives that weren't working (and cleaned up a lot of broken code for passive progression too). This includes FerroControl, FastSwim, AirAgility and ChiAgility
## Fixes
* EarthTunnel bug
> * https://trello.com/c/O1zvQT0N/831-earthtunnel-cant-be-used-on-gravel-sand-red-sand-blocks-that-are-fell
This bug was caused by blocks with gravity (sand, gravel, etc) falling into already existing TempBlocks and attempting to use EarthTunnel on these blocks. Previously it would result in nothing happening, and the block would be stuck.
This issue was caused by TempBlock not correctly checking the material type (and data!) of the already existing TempBlock when attempting to create a new instance on a pre-existing TempBlock.
This was fixed by instead of checking if `newtype` and `newdata` on the old and new TempBlock are different, it checks the actual type of the block by using `temp.block.getType()`, to get the actual values. This is because the already created TempBlock has the same type as what is trying to be set (air), and so the code to set the type again never is called.
## Additions
* Adds enable/disable option.
## Fixes
* Fixes FireManipulation being able to go through blocks.
> * https://trello.com/c/4kwGik0t/768-firemanip-bugs
## Misc. Changes
* Changes AirSweep and AirShield collision so AirSweep can pass through
AirShield.
> * https://trello.com/c/B4CdAfNV/876-airshield-blocks-airswipe
## Fixes * Run `remove()` method on all active abilities for a given player when they quit the server.
##Fixed bad Water dynamic sourcing code ##Added Earth dynamic sourcing configurability
## Errors and bugs corrected * A `ClassCastException` in `PKListener.java:onEntityDamageEvent()` would occur when a non-Living Entity took damage. * Ingots on the ground would disappear when their `ItemStack` merged with MetalClips', and the latter is removed upon colliding with an Entity. ## Improvements made * A small vertical push was given to items affected by the *magnetize* functionality of MetalClips, so that they no longer get stuck when being pulled upwards. ## Other changes * Added a `gitignore` entry to omit IntelliJ's out/ directory, which contains compiled code.
* Statistics
* Renamed KILLS to PLAYER_KILLS
* Renamed DAMAGE to PLAYER_DAMAGE
* Added TOTAL_KILLS
* Added TOTAL_DAMAGE
* Added name and displayName variables to Statistic enum
* name is used to identify the statistic from a command argument
* displayName is used when sending users statistic
* Updated the staff URL in /b who to now use HTTPS
## Additions * Adds duration to OctopusForm and WaterSpout, defaults to 0 which results in infinite usage. ## Fixes * Fixes OctopusForm adding the cooldown immediately after creation. * Fixes WaterSpout not reading/adding its cooldown correctly.
* Removed unnecessary remove() call in AirSpout constructor * Fixed NPE in FlightHandler
## Fixes * Fix WaterArms grapple ability not working * WaterArms Animation glitches fixed * EarthPillars cooldown fixed: only happens when entities are actually thrown * Fix FireCombos not working with AvatarState * Fix FireWheel not going down inclines * Fix MetalClip and Bloodbending actionbar messages
## Misc. Changes * Updates `/pk help <element>` to support Avatar as an argument. * Updates `/pk help <element>` to prompt users to enter `/pk display <element>` instead of `/pk h <elementcombos>`.
## Fixes • Fixed the updater to make it work on the new forums
## Fixes * Fix FireWheel insane wall climbing. ## Misc. Changes * Changed FireWheel default range in AvatarState config portion. * Changed WaterArms Whip Punch mode default max length in config. * Added more options to AirSwipe in AvatarState config portion. * Changed AirStream default hold duration in AvatarState config portion.
## Fixes
* Fixed fly glitch instances.
* Changed FlightHandler to handle durations individually by the identifiers to prevent overlapping of separate duration (Eg. AirSpout and AirSwipe)
* Reduced AirSwipe Flight duration from 5000ms to 1000ms to prevent unnecessary Flight access.
## Fixes * Fixes FireWheel not always damaging due to an invalid entity selection range. ## Misc. Changes * Changed WaterArms to not go through tempblocks.
## Fixes * Fixes ability redirection breaking bottlebending for that player until server restart. * Fixes WaterManipulation not working with bottles. * Fixes Surge not working with bottles.
## Misc Changes * Update README.md links to correspond with the new Wiki links.
Removed debug message from FlightHandler.java
Changed createBendingPlayer to run async
## Additions * Adds new EarthDome permissions to the plugins.yml as default ## Fixes * Fixes EarthGrab drag speed being insane and not what the config dictates * Fixed location tracking problem with EarthDome projection ## Removals * Removes EarthPillars stun function entirely ## Changes * Changes main EarthGrab use method to Left Click * Changes EarthGrab animation, now projects towards where you are looking * Changes EarthGrab trap animation, now has more particles and colored leather leggings and boots to match the block they are on * Changed EarthDome projection animation * Changed EarthGrab default config values for TrapHitInterval and TrapHP for balancing
## Additions * Adds a duration value to HealingWaters that is accurately represented by its name. ## Misc. Changes * Changes HealingWaters previous duration value to a PotionDuration in order to accurately represent what the setting represents.
## Changes * Changes EarthGrab description and instructions in the default config
## Misc. Changes
* Changes AirBlast flight time from 5000ms to 1000ms.
> * https://trello.com/c/z2zSp6lc/912-reduce-airblasts-flight-duration-from-5000ms-to-1000ms.
## Misc. Changes
* Changes onPlayerDamageByPlayer to allow offensive chi abilities and passive chi blocking to work with WarriorStance.
> * https://trello.com/c/PhcUcOav/921-warriorstance-doesnt-work-with-chi-abilities-that-damage.
…ctive element (#962) ## Fixes Fixed players being able to use passives of elements they no longer possess. - Trello Card: https://trello.com/c/xdbB8gG4 - The method removeUnusableElements in GeneralMethods takes care of this now
## Fixes
* Fixes Passives not being removed when a player has their bending changed.
* Fixes MultiAbility instances not being removed when a player has their bending changed.
* Fixes player binds not being filtered properly if they are using a MultiAbility.
* https://trello.com/c/xdbB8gG4/922-generalmethodsremoveunusableabilities-method-does-not-function-properly
## Fixes
* Fixes QuickStrike causing an endless chain of itself that never stops chiblocking and does no damage.
> * https://trello.com/c/FGK9TSmD/933-quickstrike-activates-an-endless-chain-of-itself-that-never-stops-and-deals-no-damage
## Fixes * Fixes Flight causing fly glitch w/other abilities ## Misc. Changes * Adds Override annotation to event methods * Removes accessibility to more of FlightHandler and sub-classes
|
Thank you for submitting a pull request. Currently our primary focus is to have a stable build ready to release for 1.8.7, and so we will not be adding any new features. After the update this pull request can be considered, though until then shall remain open. |
|
woa what happened to my pr |
|
Your stuff conflicts what is on the branch as of now. That's why it's being crazy |
|
Okay I’ll close this and fix it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Just thought it'd be a neat feature.