Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid lodash-merge, which is recursive and can lead to surprises #3241

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Aug 14, 2020

fixes #3240

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2020

Codecov Report

Merging #3241 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3241   +/-   ##
=======================================
  Coverage   89.32%   89.33%           
=======================================
  Files         190      190           
  Lines        3252     3253    +1     
=======================================
+ Hits         2905     2906    +1     
  Misses        347      347           
Impacted Files Coverage Δ
src/state/reducers/companionWindows.js 100.00% <100.00%> (ø)
src/state/reducers/elasticLayout.js 100.00% <100.00%> (ø)
src/state/reducers/windows.js 96.15% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f705d12...1ccb297. Read the comment docs.

@cbeer cbeer marked this pull request as ready for review August 14, 2020 18:03
@mejackreed mejackreed merged commit 252ef76 into master Aug 17, 2020
@mejackreed mejackreed deleted the 3240-merge-nonrecursive branch August 17, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Book view: navigating to previous item displays wrong canvas (1st canvas only)
3 participants