Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections initialization proposal #1. #3249

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Collections initialization proposal #1. #3249

merged 4 commits into from
Oct 13, 2020

Conversation

mejackreed
Copy link
Collaborator

@mejackreed mejackreed commented Sep 5, 2020

Pros: just keep using manifestId to initialize a miradorInstance
Cons: this starts to break down in some places and we have to end up
monkeypatching Manifesto. Other parts of the Mirador Window also make
other assumptions.

Update

After technical discussions this approach is preferred over #3250
image

Partially addresses #3248

Pros: just keep using manifestId to initialize a miradorInstance
Cons: this starts to break down in some places and we have to end up
monkeypatching Manifesto. Other parts of the Mirador Window also make
other assumptions.
@mejackreed mejackreed force-pushed the collections-prop-1 branch 4 times, most recently from 6be4564 to 1fb17c7 Compare October 12, 2020 22:41
@mejackreed mejackreed marked this pull request as ready for review October 12, 2020 22:44
@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #3249 into master will increase coverage by 0.13%.
The diff coverage is 61.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3249      +/-   ##
==========================================
+ Coverage   89.33%   89.47%   +0.13%     
==========================================
  Files         190      195       +5     
  Lines        3253     3600     +347     
==========================================
+ Hits         2906     3221     +315     
- Misses        347      379      +32     
Impacted Files Coverage Δ
src/components/SelectCollection.js 0.00% <0.00%> (ø)
src/state/actions/action-types.js 100.00% <ø> (ø)
src/state/sagas/app.js 84.61% <ø> (ø)
src/state/actions/window.js 96.29% <50.00%> (-3.71%) ⬇️
src/components/CollectionDialog.js 60.86% <60.00%> (+4.11%) ⬆️
src/state/selectors/manifests.js 95.55% <66.66%> (-2.10%) ⬇️
src/components/PrimaryWindow.js 100.00% <100.00%> (ø)
src/state/reducers/windows.js 96.42% <100.00%> (+0.27%) ⬆️
src/state/sagas/windows.js 85.54% <100.00%> (+0.73%) ⬆️
src/state/reducers/accessTokens.js 77.27% <0.00%> (-14.40%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b15cbb6...3010641. Read the comment docs.

@cbeer cbeer merged commit 2cddf26 into master Oct 13, 2020
@cbeer cbeer deleted the collections-prop-1 branch October 13, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants