-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should the links from our navigation bar be relative? #263
Comments
That's by design. There are other links further down in the page that are relative that will take you to the locally hosted site. |
That indeed works. Thanks. However, I'm not sure what to do about the confusion our contributor's guide will cause. Any thoughts @kmpaul ? |
I think we should just include a warning that (1) any external links from the locally built site (or in the preview) will take you away from the preview and (2) any internal links in the top menubar will take you away from the preview, too. |
It might be possible to make the internal links in the top-bar relative. I'll have to look into that. |
Thanks. I don't think it is high priority because it is mostly the Pythia team that touches the landing pages. |
Having them be absolute links helps with consistency across the sites, I think. The low hanging fruit would be to add the warning to the contributor's guide. |
Many (all) of the links from our top level navigation bar menu items, such as the one under Community below, are full URLs (not relative links). Hence previewing locally as described in our contributors guide here is not possible: the link takes you to the production site.
projectpythia.github.io/portal/conf.py
Line 103 in 57407bf
The text was updated successfully, but these errors were encountered: