Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box of Achievements #944

Open
Undercova opened this issue Jun 25, 2014 · 34 comments
Open

Box of Achievements #944

Undercova opened this issue Jun 25, 2014 · 34 comments
Labels

Comments

@Undercova
Copy link
Member

box_of_achievements

http://swg.wikia.com/wiki/Box_of_Achievements

@Undercova Undercova added this to the End of TC milestone Jun 25, 2014
@madsboddum
Copy link
Member

I don't think this has to be in by the end of TC - just before we implement any instances.

@Undercova
Copy link
Member Author

it also contains the GCW tokens from BFs and didnt we want to put BFs in too for "End of TC" ?

@madsboddum
Copy link
Member

Not as far as I can tell from the notes written on the milestone.

@madsboddum
Copy link
Member

I surrender. I'll create the token box now.

@madsboddum madsboddum self-assigned this Jun 26, 2014
@Mesagoppinmypants
Copy link
Contributor

So battlefields will be in at the end of the TC?

@lewismorgan
Copy link
Contributor

It's possible that they could be. I know treeku has been looking at it while he was doing some GCW stuff

@madsboddum
Copy link
Member

I need a way to check if a player has the box. The same check will be needed for the Master Jedi Cloak Collection, to prevent robe duping (which worked so well). Does such a method exist?

@Undercova
Copy link
Member Author

i think the box was permanently in inventory. you couldnt put it somewhere else like bank or drop it.

@CharonInferar
Copy link
Contributor

Maybe the PlayerObject could be added a collection that holds items that can be only had once.
The items can be Identified possibly by the "unique" attribute. Certainly some way to prevent duping needs to be implemented.

@Treeku
Copy link
Contributor

Treeku commented Jun 27, 2014

Charon: For "unique" items we should add a check that prevents two objects of the same template (or stfName) being added to the same container if they both have the "unique" attribute. This check might have to go in the engine. They normally won't be able to get it again though because they won't be able to do most quests twice. Quests will usually check against if the quest already exists in the questhistory, or check against the existance collections.

The box works like this:

Token is destroyed, relevent attribute is incremented.

I don't think the box is really urgent, but if someone wants to implement it, go ahead.

@Treeku
Copy link
Contributor

Treeku commented Jun 27, 2014

Undercova: You could only put unique items into your bank. You could not put them into a house, a backpack or some other containers because of the possibility of someone else getting admin to it and picking up your unique item.

@lewismorgan
Copy link
Contributor

@Ziggeh you can just put in the object ID for the box in PlayerObject probably. That would be the easiest so you don't have to traverse through the inventory.

@madsboddum
Copy link
Member

@waverunner will the same have to be done with the Master Jedi Cloaks?

@lewismorgan
Copy link
Contributor

@Ziggeh depends on what you're doing. The players box of achievements having it's object id put inside PlayerObject makes sense considering how often you would probably want to retrieve the object in scripting and regular server coding. It would be really annoying having to do a traverser inside a python script, I haven't attempted it and there would probably need to be a specific method just for that (Or can make a getInventory method that traverses all the items, adds items to the list, and returns the list, that would be a lot easier to use in scripting.)

@madsboddum
Copy link
Member

Maybe a hasItemInInventory(String itemTemplate, CreatureObject creature) method which returns true or false depending on whether the player actually has the item or not. Such a method should be fairly universal.

@lewismorgan
Copy link
Contributor

Yeah that would be a good idea, it could probably just go directly into CreatureObject so there would be no need for a creo argument.

@Undercova
Copy link
Member Author

afaik ... you could also have only one of the auto loom units in your inventory ... at least the JD wouldnt give you a new one ... until you dropped the other one into bank or house. atm you can get unlimited amount of them without the need to drop them

@madsboddum
Copy link
Member

The implementation of this method will make it possible to prevent that @Undercova. The same applies to the Master Jedi Cloaks.

@madsboddum
Copy link
Member

Another idea: Make a method that returns a list of SWGObjects by a stfName. I will be needing this anyways. Then, to check if the player even has the item, use isEmpty()

@madsboddum
Copy link
Member

The method I suggested above: 777db5d

@madsboddum
Copy link
Member

I need some information on the message that would pop up when adding tokens to the Box of Achievements. Location in the stf tables, a screenshot, a video, anything. I can't remember what it said precisely.

@Undercova
Copy link
Member Author

In commemoration of your your success this day you are awarded Droid Factory Token of Heroism!

the Token name in cyan color

@madsboddum
Copy link
Member

I have found that one in set_bonus.stf

The one I am looking for is when adding the tokens to your Box of Achiements, like specified in my comment above.

@Undercova
Copy link
Member Author

dont they get put in there automatically ? at least the heroic ones

@madsboddum
Copy link
Member

No, I think you added them manually each time.

@lewismorgan
Copy link
Contributor

I remember having to put them in the box myself.

@madsboddum
Copy link
Member

I tried looking at a few videos on YouTube of some people doing instances, hoping to see them add the tokens to the box - no luck.

@Undercova
Copy link
Member Author

when you had no box ... you didnt get tokens when finishing heroics. thats why you HAD to finish that small quest to get the box first

@madsboddum
Copy link
Member

That's not true.

@ghost
Copy link

ghost commented Jul 1, 2014

I have a screenshot with heroic tokens in my inventory not in box if needed. To believe we had a radial option to add to the box

On Jul 1, 2014, at 12:56 PM, Undercova notifications@github.com wrote:

heroics were instant in box

bf tokens might have been in inventory ... chronicler in inventory


Reply to this email directly or view it on GitHub.

@Undercova
Copy link
Member Author

http://youtu.be/A9RDygtfv4o?t=3m5s

it is in inventory. but no trade. so why not put it straight into box? :D

@madsboddum
Copy link
Member

Thank you @Undercova - that was just what I was looking for.

@ghost
Copy link

ghost commented Jul 1, 2014

I had a friend that maxed his heroic tokens out in the box at 99 each. Probably thats why

On Jul 1, 2014, at 1:04 PM, Undercova notifications@github.com wrote:

http://youtu.be/A9RDygtfv4o?t=3m5s

it is in inventory. but no trade. so why not put it straight into box? :D


Reply to this email directly or view it on GitHub.

@madsboddum
Copy link
Member

Now to find this in the stf tables somewhere.

@madsboddum madsboddum removed their assignment Jul 25, 2014
@madsboddum madsboddum removed this from the End of Frog milestone Aug 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants