-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Box of Achievements #944
Comments
I don't think this has to be in by the end of TC - just before we implement any instances. |
it also contains the GCW tokens from BFs and didnt we want to put BFs in too for "End of TC" ? |
Not as far as I can tell from the notes written on the milestone. |
I surrender. I'll create the token box now. |
So battlefields will be in at the end of the TC? |
It's possible that they could be. I know treeku has been looking at it while he was doing some GCW stuff |
I need a way to check if a player has the box. The same check will be needed for the Master Jedi Cloak Collection, to prevent robe duping (which worked so well). Does such a method exist? |
i think the box was permanently in inventory. you couldnt put it somewhere else like bank or drop it. |
Maybe the PlayerObject could be added a collection that holds items that can be only had once. |
Charon: For "unique" items we should add a check that prevents two objects of the same template (or stfName) being added to the same container if they both have the "unique" attribute. This check might have to go in the engine. They normally won't be able to get it again though because they won't be able to do most quests twice. Quests will usually check against if the quest already exists in the questhistory, or check against the existance collections. The box works like this: Token is destroyed, relevent attribute is incremented. I don't think the box is really urgent, but if someone wants to implement it, go ahead. |
Undercova: You could only put unique items into your bank. You could not put them into a house, a backpack or some other containers because of the possibility of someone else getting admin to it and picking up your unique item. |
@Ziggeh you can just put in the object ID for the box in PlayerObject probably. That would be the easiest so you don't have to traverse through the inventory. |
@waverunner will the same have to be done with the Master Jedi Cloaks? |
@Ziggeh depends on what you're doing. The players box of achievements having it's object id put inside PlayerObject makes sense considering how often you would probably want to retrieve the object in scripting and regular server coding. It would be really annoying having to do a traverser inside a python script, I haven't attempted it and there would probably need to be a specific method just for that (Or can make a getInventory method that traverses all the items, adds items to the list, and returns the list, that would be a lot easier to use in scripting.) |
Maybe a hasItemInInventory(String itemTemplate, CreatureObject creature) method which returns true or false depending on whether the player actually has the item or not. Such a method should be fairly universal. |
Yeah that would be a good idea, it could probably just go directly into CreatureObject so there would be no need for a creo argument. |
afaik ... you could also have only one of the auto loom units in your inventory ... at least the JD wouldnt give you a new one ... until you dropped the other one into bank or house. atm you can get unlimited amount of them without the need to drop them |
The implementation of this method will make it possible to prevent that @Undercova. The same applies to the Master Jedi Cloaks. |
Another idea: Make a method that returns a list of SWGObjects by a stfName. I will be needing this anyways. Then, to check if the player even has the item, use isEmpty() |
The method I suggested above: 777db5d |
I need some information on the message that would pop up when adding tokens to the Box of Achievements. Location in the stf tables, a screenshot, a video, anything. I can't remember what it said precisely. |
In commemoration of your your success this day you are awarded Droid Factory Token of Heroism! the Token name in cyan color |
I have found that one in set_bonus.stf The one I am looking for is when adding the tokens to your Box of Achiements, like specified in my comment above. |
dont they get put in there automatically ? at least the heroic ones |
No, I think you added them manually each time. |
I remember having to put them in the box myself. |
I tried looking at a few videos on YouTube of some people doing instances, hoping to see them add the tokens to the box - no luck. |
when you had no box ... you didnt get tokens when finishing heroics. thats why you HAD to finish that small quest to get the box first |
That's not true. |
I have a screenshot with heroic tokens in my inventory not in box if needed. To believe we had a radial option to add to the box
|
http://youtu.be/A9RDygtfv4o?t=3m5s it is in inventory. but no trade. so why not put it straight into box? :D |
Thank you @Undercova - that was just what I was looking for. |
I had a friend that maxed his heroic tokens out in the box at 99 each. Probably thats why
|
Now to find this in the stf tables somewhere. |
http://swg.wikia.com/wiki/Box_of_Achievements
The text was updated successfully, but these errors were encountered: