3314 Gallery View Unresponsive

[cyrusnaficy]

Resolves #3314

Updated the currSelected variable so it is in the modal class. Now it resets whenever the modal closes so that the expanded view clicking works 100% of the time.

Testing instructions

1. Open GalleryView
2. Open the expanded view and press agree/disagree or thumbs up/thumbs down.
3. Go to another gallery view and do the same.

Things to check before submitting the PR

• I've written a descriptive PR title.
• I've added/updated comments for large or confusing blocks of code.

[misaugstad]

I think that it's more appropriate to keep the currSelected variable that tracks the label's validation in ValidationMenu instead of moving it up to Modal! I think that it just needs to be set to null at the right time.

The currSelected variable is correctly set to agree/disagree/unsure when moving to a new label in ValidationMenu in the function showValidationOnExpandedView(). In updateReferenceCard(), either showValidationOnExpandedView() is called if there is a user validation for the new label or _removeValidationVisualsOnExpandedView() if there is not. So it seems that setting currSelected to null in _removeValidationVisualsOnExpandedView() would probably do it!

[cyrusnaficy]

I think that it's more appropriate to keep the currSelected variable that tracks the label's validation in ValidationMenu instead of moving it up to Modal! I think that it just needs to be set to null at the right time.

The currSelected variable is correctly set to agree/disagree/unsure when moving to a new label in ValidationMenu in the function showValidationOnExpandedView(). In updateReferenceCard(), either showValidationOnExpandedView() is called if there is a user validation for the new label or _removeValidationVisualsOnExpandedView() if there is not. So it seems that setting currSelected to null in _removeValidationVisualsOnExpandedView() would probably do it!

Thanks, that makes a lot of sense. Didn't realize that function was also being called when the modal closes. Really appreciate the help!

[misaugstad]

Seems to be working great!