Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selection box for PSM-level normalisation #75

Closed
jgriss opened this issue Sep 26, 2018 · 4 comments
Closed

Add selection box for PSM-level normalisation #75

jgriss opened this issue Sep 26, 2018 · 4 comments

Comments

@jgriss
Copy link
Collaborator

jgriss commented Sep 26, 2018

  • Allow users to set the used PSM level normalization
  • This is currently hard-coded to "center.median"
  • Possible values (in MSnbase) are:
    • max
    • sum
    • quantiles
    • quantiles.robust
    • center.mean
    • center.median
@jgriss
Copy link
Collaborator Author

jgriss commented Sep 26, 2018

Note: max and sum work on the features (= rows) while the others work on the columns. It might be worth testing whether it's sensible to combine the two.

@jgriss jgriss added the question label Oct 3, 2018
@jgriss
Copy link
Collaborator Author

jgriss commented Oct 3, 2018

@veitveit Based on the benchmarks center.median seems to be working best.

To keep the protocol simple, we might also just not add this parameter.

Alternatively, we could add an "advanced parameters" section. What do you think?

In any case, I'm scheduling this for the version after the next one.

@jgriss jgriss added this to the version 0.3 milestone Oct 3, 2018
@veitveit
Copy link
Collaborator

veitveit commented Oct 5, 2018 via email

@jgriss
Copy link
Collaborator Author

jgriss commented Oct 8, 2018

Agreed. Let's not add this parameter.

@jgriss jgriss closed this as completed Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants