Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Pull SampleID from Thermo RAW files as annotation in Skyline #494

Merged
merged 3 commits into from
Apr 8, 2019

Conversation

chambm
Copy link
Member

@chambm chambm commented Mar 29, 2019

  • added RawFile::getSampleID(), which is added to the MSData model as the MS_sample_name of a Sample element
  • added MsDataFileImpl::GetSampleId(), which gets a nullable string from that MS_sample_name value

This is reference to issue 628:

Jaffe lab has requested the ability to automatically set replicate attribute based on some properties in the Thermo RAW file header. ProteoWizard can write these properties to the MSData fileContent section as userParams if they are present and/or non-empty, where Skyline can look for them and use them appropriately.

The current branch has the requested property in the MSData model and an easy getter function in MSDataFileImpl.

@brendanx67 / @nickshulman Do you want me to go ahead and try to do the annotation part too?

… the MS_sample_name of a Sample element

* added MsDataFileImpl::GetSampleId(), which gets a nullable string from that MS_sample_name value
@chambm chambm changed the title Pull SampleID from Thermo RAW files as annotation in Skyline WIP: Pull SampleID from Thermo RAW files as annotation in Skyline Mar 29, 2019
@chambm
Copy link
Member Author

chambm commented Apr 8, 2019

@nickshulman does approval mean you want to handle the Skyline side of this?

@nickshulman
Copy link
Contributor

@nickshulman does approval mean you want to handle the Skyline side of this?

Yes, I should do the Skyline side of this. It will probably require changing our .skyd file format a little bit, since the easiest way to remember the value of this attribute that we read during chromatogram extraction is to store it in the .skyd file before eventually copying it into the .sky file.

@chambm chambm merged commit 7e6b8de into master Apr 8, 2019
@chambm chambm deleted the Skyline/work/20190329_ThermoSampleID branch April 8, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants