-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add varshort data type #52
Conversation
Extended 'short' type, see http://wiki.vg/Minecraft_Forge_Handshake#Definitions
Can you add it in https://github.com/roblabla/ProtoDef/blob/master/doc/datatypes.md#utils ? |
Added |
I'm not 100% sure whether this should be in ProtoDef or in nmp though. Does this exist anywhere but in minecraft protocol ? |
Now that nmp has a customPackets option, this could even move to nmp-forge. We can always move things to nmp or protodef if it's useful in general anyway. Or can you think of an other thing that forge that would use this ? |
(trying not to bloat protodef with too many default types) |
stop Could we please have generalized |
No varshort is completely different than varint/varlong despite the similar name. It's backwards-compatible with But to rom's point, I think it would make sense to move this to nmp-forge, as that is all that uses it (Forge invented this "varshort" data type): PrismarineJS/node-minecraft-protocol-forge#1 (though I'll need some means to modify the 0x3f packet definition before passed to the serializer) |
seems like we haven't needed this |
Extended 'short' type, see http://wiki.vg/Minecraft_Forge_Handshake#Definitions
With this PR and minecraft-data 1.7 plugin_channel 0x3f updated to varshort, able to login to an FTBInfinityServer-2.3.5-1.7.10 server (although it later crashes due to use of other custom packets)
ref PrismarineJS/node-minecraft-protocol-forge#7
Closes PrismarineJS/node-minecraft-protocol-forge#1 (couldn't make the change in nmp-f because it requires changing the protocol definition in minecraft-data unfortunately, but it is backwards-compatible with vanilla 1.7)