x second timer's image won't change when activated directly

[OnsenManju]

If 1/3/5 second timer was activated by right-clicking, its image won't turn the light on. It shows correctly on vanilla server or singleplayer.
Vanilla server

TShock 4.3.22

But when the timer was activated by other item (e.g. lever, switch, pressure plate), it lights on normally.

[OnsenManju]

I just now noticed the lever also won't change its direction when being right-clicked.

[levi-middleton]

Yes. It seems like all the toggleables stay in their initial state.

[DogooFalchion]

Likely the same issue as campfires, these tiles need to be exempted from the right click->edit world protection tshock runs. Makes me wonder if TSAPI used to insert a toggleable property like explosives is done.

[QuiCM]

Could not reproduce on bleeding edge build. Release however has this issue

[ivanbiljan]

As mentioned in #1421, it's seems to be caused by the HitSwitch packet.
@OnsenManju would you mind testing it with this https://www.dropbox.com/s/duv3c5jyjpqqzib/TShockAPI.dll?dl=0

[OnsenManju]

@ProfessorXz
Tested all triggers that have toggle-able images and can be activated by right-clicking.

              | TShock 4.3.23             | Test build      |
--------------+---------------------------+-----------------+
1/3/5 Timer   |                           |                 |
Switch        | image is unchanged        | same as vanilla |
Lever         |                           |                 |
--------------+---------------------------+-----------------+
Detonator     | won't revert once pressed | same as vanilla |
--------------+---------------------------+-----------------+
Trapped Chest | same as vanilla           | same as vanilla |
--------------+---------------------------+-----------------+

All of the above worked successfully with your test build. Awesome!
(Confirmed on Windows7 and Linux+Mono 4.8.0)

[ivanbiljan]

@OnsenManju Thanks for the feedback, your reports are 10/10 :)
I'll PR the changes once the project is ready again.

[mistzzt]

This should be fixed by latest commit #edad442e

[Ijwu]

Closing this on the basis that it is a very similar issue to #1421 and that issue was solved by edad442. Please re-open and comment if this is not fixed.