Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update json library if possible #1526

Closed
hakusaro opened this issue Dec 6, 2017 · 6 comments
Closed

Update json library if possible #1526

hakusaro opened this issue Dec 6, 2017 · 6 comments

Comments

@hakusaro
Copy link
Member

hakusaro commented Dec 6, 2017

If possible, update Newtonsoft's JSON library to the newest version across here and the other API related projects.

@edg-l
Copy link
Contributor

edg-l commented Dec 6, 2017

I promise ill do the pr when i can

@hakusaro hakusaro removed the Pending label Dec 6, 2017
@hakusaro
Copy link
Member Author

hakusaro commented Dec 6, 2017

Kk, you have a day or two.

@QuiCM
Copy link
Member

QuiCM commented Dec 6, 2017

Should we keep parity with vanilla terraria?

@Ijwu
Copy link
Contributor

Ijwu commented Dec 6, 2017

OTAPI rewrites the TServer binary to update references, doesn't it? That, or binding redirects will, by default, keep parity.

I don't foresee this being an issue.

@QuiCM
Copy link
Member

QuiCM commented Dec 6, 2017

All good then, no more questions from me

@hakusaro
Copy link
Member Author

hakusaro commented Dec 9, 2017

Tried updating to latest OTAPI in TSAPI with nuget and completely failed, so I'm going to leave this one to someone else.

Kurisu 福 ~/development/terrariaapi-server ➤ 3b8f6d1|general-devel⚡
2057 ± : mono ~/bin/nuget.exe update *.sln -Id OTAPI
Scanning for projects...
MSBuild auto-detection: using msbuild version '14.0' from '/usr/local/Cellar/mono/5.0.1.1/lib/mono/xbuild/14.0/bin'.
Found 5 projects with a packages.config file. (TShock.Modifications.Bootstrapper.csproj, TShock.Modifications.ClientUUID.csproj, TShock.Modifications.Explosives.csproj, TShock.Modifications.Platform.csproj, TShock.Modifications.SSC.csproj)
Feeds used:
  https://api.nuget.org/v3/index.json



Attempting to gather dependency information for multiple packages with respect to project '/Users/hakusaro/Development/TerrariaAPI-Server/TShock.Modifications.Bootstrapper/TShock.Modifications.Bootstrapper.csproj', targeting 'Unsupported,Version=v0.0'
Gathering dependency information took 1.61 sec
Attempting to resolve dependencies for multiple packages.
WARNING: One or more unresolved package dependency constraints detected in the existing packages.config file. All dependency constraints must be resolved to add or update packages. If these packages are being updated this message may be ignored, if not the following error(s) may be blocking the current package operation: 'OTAPI 2.0.0.29 constraint: Newtonsoft.Json (>= 9.0.1)'
Resolving dependency information took 0 ms
Resolving actions install multiple packages
Retrieving package 'Newtonsoft.Json 10.0.3' from 'nuget.org'.
Retrieving package 'OTAPI 2.0.0.31' from 'nuget.org'.
WARNING: Install failed. Rolling back...
WARNING: Package 'Newtonsoft.Json 10.0.3' does not exist in project 'TShock.Modifications.Bootstrapper.csproj'
Executing nuget actions took 95.84 ms
WARNING: Could not install package 'Newtonsoft.Json 10.0.3'. You are trying to install this package into a project that targets 'Unsupported,Version=v0.0', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
Feeds used:
  https://api.nuget.org/v3/index.json

Executing nuget actions took 0.93 ms
Feeds used:
  https://api.nuget.org/v3/index.json

Executing nuget actions took 0.23 ms
Feeds used:
  https://api.nuget.org/v3/index.json



Attempting to gather dependency information for multiple packages with respect to project '/Users/hakusaro/Development/TerrariaAPI-Server/TShock.Modifications.Platform/TShock.Modifications.Platform.csproj', targeting 'Unsupported,Version=v0.0'
Gathering dependency information took 228.02 ms
Attempting to resolve dependencies for multiple packages.
WARNING: One or more unresolved package dependency constraints detected in the existing packages.config file. All dependency constraints must be resolved to add or update packages. If these packages are being updated this message may be ignored, if not the following error(s) may be blocking the current package operation: 'OTAPI 2.0.0.29 constraint: Newtonsoft.Json (>= 9.0.1)'
Resolving dependency information took 0 ms
Resolving actions install multiple packages
Retrieving package 'Newtonsoft.Json 10.0.3' from 'nuget.org'.
Retrieving package 'OTAPI 2.0.0.31' from 'nuget.org'.
WARNING: Install failed. Rolling back...
WARNING: Package 'Newtonsoft.Json 10.0.3' does not exist in project 'TShock.Modifications.Platform.csproj'
Executing nuget actions took 21.55 ms
WARNING: Could not install package 'Newtonsoft.Json 10.0.3'. You are trying to install this package into a project that targets 'Unsupported,Version=v0.0', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
Feeds used:
  https://api.nuget.org/v3/index.json



Attempting to gather dependency information for multiple packages with respect to project '/Users/hakusaro/Development/TerrariaAPI-Server/TShock.Modifications.SSC/TShock.Modifications.SSC.csproj', targeting 'Unsupported,Version=v0.0'
Gathering dependency information took 229.96 ms
Attempting to resolve dependencies for multiple packages.
WARNING: One or more unresolved package dependency constraints detected in the existing packages.config file. All dependency constraints must be resolved to add or update packages. If these packages are being updated this message may be ignored, if not the following error(s) may be blocking the current package operation: 'OTAPI 2.0.0.29 constraint: Newtonsoft.Json (>= 9.0.1)'
Resolving dependency information took 0 ms
Resolving actions install multiple packages
Retrieving package 'Newtonsoft.Json 10.0.3' from 'nuget.org'.
Retrieving package 'OTAPI 2.0.0.31' from 'nuget.org'.
WARNING: Install failed. Rolling back...
WARNING: Package 'Newtonsoft.Json 10.0.3' does not exist in project 'TShock.Modifications.SSC.csproj'
Executing nuget actions took 26.81 ms
WARNING: Could not install package 'Newtonsoft.Json 10.0.3'. You are trying to install this package into a project that targets 'Unsupported,Version=v0.0', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

No, I don't know what I'm doing. Thanks for asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants