Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version checks for guppy and lib #13

Closed
Psy-Fer opened this issue Jun 7, 2023 · 2 comments
Closed

Add version checks for guppy and lib #13

Psy-Fer opened this issue Jun 7, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Psy-Fer
Copy link
Owner

Psy-Fer commented Jun 7, 2023

After starting the guppy server but before connecting a client, I should do a check that the guppy server version matches the installed guppy client lib version.

I think I can do this with some API calls to the server and some lib version check stuff for the lib.

This should help give a more informative error in the case where they don't match but the output is...weird and not helpful.

@Psy-Fer Psy-Fer added the enhancement New feature or request label Jun 7, 2023
@Psy-Fer Psy-Fer self-assigned this Jun 7, 2023
@Psy-Fer
Copy link
Owner Author

Psy-Fer commented Jun 7, 2023

Ahh i already do such a lib check using

major, minor, patch = [int(i) for i in pyguppy_client_lib.__version__.split(".")]

@Psy-Fer
Copy link
Owner Author

Psy-Fer commented Aug 16, 2024

Add this into the lib checks, with the exception that 7.3.9 and 7.3.10 are the same, and not wrong.

@Psy-Fer Psy-Fer closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant