Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group age into age bands #23

Closed
terrymclaughlin opened this issue Feb 7, 2020 · 7 comments · Fixed by #27
Closed

Group age into age bands #23

terrymclaughlin opened this issue Feb 7, 2020 · 7 comments · Fixed by #27
Assignees
Labels
enhancement New feature or request

Comments

@terrymclaughlin
Copy link

I have a function that I use regularly that takes a vector of numeric values (i.e. people's ages) and groups them into age bands ages based on parameters provided to the function.

I think this would be a function that many of our analysts could make regular use of. Would you be happy for me to contribute this to the package? I'd be happy to receive feedback on the function as well if it can be improved at all.

@jvillacampa
Copy link
Contributor

Hi @terrymclaughlin,
I think @chrisdeans is doing something in those lines in the branch get_agegroup. Maybe worth chatting/collaborating with him?

@davidc92
Copy link
Contributor

davidc92 commented Feb 7, 2020

Hi @terrymclaughlin,
I think @chrisdeans is doing something in those lines in the branch get_agegroup. Maybe worth chatting/collaborating with him?

Yup, @jvillacampa is correct. @chrisdeans has already written some code for this and already created a branch. Might be worth checking in with him.

@terrymclaughlin
Copy link
Author

Hi @terrymclaughlin,
I think @chrisdeans is doing something in those lines in the branch get_agegroup. Maybe worth chatting/collaborating with him?

Ah, great. I didn't realise @chrisdeans was already working on this. I will speak to him. Thanks!

@davidc92
Copy link
Contributor

davidc92 commented Feb 7, 2020

We should keep this open until the branch is merged and the function is live. It will help avoid duplication in the future :)

@davidc92 davidc92 reopened this Feb 7, 2020
@jackhannah95
Copy link
Contributor

Hi @terrymclaughlin and @chrisdeans,

Have you guys discussed this at all? Chris' branch has been open for a while and we'd be keen to incorporate a function of this sort into the package as soon as possible.

@chrisdeans
Copy link
Contributor

Hi @jackhannah95, Terry and I discussed this last month and I added his suggestions to the branch. @RoisinF is checking the code at the moment.

@jackhannah95
Copy link
Contributor

Ok great 👍 When you're ready to open a PR, I'll do a review as well and merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants