Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish should be a no-op if no units and no settings have changed since the last publish #232

Closed
ipanova opened this issue May 5, 2016 · 3 comments

Comments

@ipanova
Copy link
Member

ipanova commented May 5, 2016

Test that Publish should be a no-op if all of the following are true:

  • no units have been added since the last successful publish.
  • no units have been removed since the last successful publish.
  • no distributor has been modified since the last successful publish.

For more info check https://pulp.plan.io/issues/1724
There is already implemented one test that is related #127 but i think that testing these 3 corner cases will be also good.

@ipanova
Copy link
Member Author

ipanova commented May 26, 2016

One more corner case would be good to test when some values where specified in the override_config of the current publish - at this point publish should be operational.

@ipanova
Copy link
Member Author

ipanova commented Jun 3, 2016

scenario1

  1. create repo with feed, sync, publish
    2 assert publish is operational
    3 remove unit/add unit/ update distributor's config( like disable publish over http)
    4 publish
    5 assert publish is operational

scenario2
1 create sync repo, publish
2 assert publish is operational
3 publish repo and set override config
4 assert publish is operational

scenario3
1 create sync repo, publish
2 assert publish is operational
3 publish repo and set override config with values X
4 assert publish is operational
5 publish repo and set override config with values X( override config should be same as in step3)
6 assert publish is no-op

@midnightercz
Copy link
Contributor

Tests in #290
scenario3 covered with NOOPTestCase1
scenario1 coverred with NOOPTestCase2
scenario2 seems to be subset of scenario3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants