-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add api.task_handler and related Client.using_handler #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochacbruno
added a commit
to rochacbruno/pulp-certguard
that referenced
this pull request
Mar 18, 2019
- Add testcase for certguard api (assert protected distribution) - Add a bunch if `dummy` generated self-signed certificates for testing purposes Requires PRs: pulp/pulp-smash#1184 pulp/pulp-smash#1185 pulp/pulp-smash#1186 pulp/pulp-smash#1187 Related issues: https://pulp.plan.io/issues/4122 https://pulp.plan.io/issues/3969 https://pulp.plan.io/issues/3970 closes #4122
rochacbruno
added a commit
to rochacbruno/pulp-certguard
that referenced
this pull request
Mar 19, 2019
- Add testcase for certguard api (assert protected distribution) - Add a some `dummy` generated self-signed certificates for testing purposes Related PRs: pulp/pulp-smash#1185 pulp/pulp-smash#1186 pulp/pulp-smash#1187 Related issues: https://pulp.plan.io/issues/4122 https://pulp.plan.io/issues/3969 https://pulp.plan.io/issues/3970 closes #4122 Required PR: pulp/pulp-smash#1184
nixocio
reviewed
Mar 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we talked task_handler it is a pulp 3 only response_handler.
1. Add new handler to extract created/updated resources from task's call_report 2. Add `syntax-sugar` method `Client.using_handler` to save few lines of code and some aditional imports when having to use a different handler o a client.
rochacbruno
force-pushed
the
add_task_handler
branch
from
March 21, 2019 15:02
c50e124
to
9e7faf5
Compare
nixocio
approved these changes
Mar 21, 2019
ragabala
approved these changes
Mar 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Add new handler to extract created/updated resources from task's call_report
Usage examples:
Create a distribution using
json_handler
Create a distribution using
task_handler
Having an existent client it is possible to use the shortcut::
2. Add
syntax-sugar
methodClient.using_handler
to save few lines of code and some aditional imports when having to use a different handler o a client.
This method clones and injects a new handler dependency in to the
existing client instance and then returns it.
This method is offered just as a 'syntax-sugar' for:
with this method the above can be done in a single line without extra imports:
Closes #1178
Ref #1181 (may close it)