Overhaul CI and apply code format #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixocio
force-pushed
the
change_code_format_clean_prs
branch
from
4c20591
to
d3ee8c8
Compare
This PR does: * Drop Python 3.4 support. * Drop linters from setup.py * Adopt black code sytle. * Fix flake8 issues. * Remove pylint as linter. * Update MakeFile. * Update Docs.
nixocio
force-pushed
the
change_code_format_clean_prs
branch
from
d3ee8c8
to
14996ca
Compare
|
This is the first big change, there are many other hooks to add to pre-commit. For instance: https://pre-commit.com/hooks.html With time we can add those, and adjust the code as needed. |
rochacbruno
approved these changes
Mar 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does: