-
Notifications
You must be signed in to change notification settings - Fork 287
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panasonic - some inputs repeated #326
Comments
Same for me, since I have upgraded to Krypton I'm experiencing the same behaviour with my TV. As you already said, It occurs occasionally, when any key of remote control is pressed 2 times, Kodi interprets it as 3 times. For debugging, I enabled the verbose logging for CEC, to see if 2 key presses are received 3 times. I have attached the log file, thus you can verify I have not misinterpreted the logging. My CEC configuration: Testing: Any suggestions? |
I'm seeing this bug after upgrading to libcec 3.1.0 or 4.0.2 from 3.0.1 which was working fine. Firmware 5. From changelog libcec 3.1.0:
What other means? Anyone on firmware 7 with this bug? Where is the firmware changelog? |
I reverted this "skip double press removal" commit on 4.0.2 and re-built it. Not more double presses :-) |
so... |
@gdave321 Didn't you got some conflicts, when reverting to the recent source-code version. I got some by doing the revert, so could you share a patch or make pull request? |
Can confirm. Annoying double presses in Kodi 17 on Arch Linux using the USB adapter with a Sony TV (2017 model). |
This is patch I used on 4.0.2 to revert the change. |
I could be wrong, but I think it's fixed for me after updating the adapter to firmware v7. I need to test is more, though. |
@gdave321 thanks for sharing, also works for me! |
I was wrong, updating the firmware to v7 did not fix this issue. Extremely annoying.. |
The firmware version doesn't affect key presses, but only low level things like bit timings and waking up the PC from standby/off. Can you try this (response to another ticket about this):
|
Deleted peripheral_data and reinstalled libcec: double taps are back immediately. The xml file inside peripheral_data was not recreated by kodi, so the issue happens with default settings without ever changing any peripheral settings inside Kodi. |
I want to add that double presses don't happen on every key press, just on any fifth press (or so) in average. |
The xml in peripheral_data is created by Kodi :) |
I can do so on the weekend. |
Thanks |
Sorry, the weekend was shorter than expected. I will come back to you :) |
Here you go: Included is the startup of Kodi, including the initializing of libcec. At line 1720 I cut out a bunch of unimportant lines. Starting at that line until the end of the log I pressed a button (up or down) on my IR remote pretty much exactly every 3 seconds, using a stopwatch. As you can see, sometimes libcec recognized two presses in one second. My remote is very clicky, a lot like mouse buttons, so there is no way that I actually accidentaly pressed a button two times in one second. The very last recognized key press in the attached log file is one of these falsely recognized double presses. Whenever you see It may be of importance that my TV (Sony KD-XE9005) is not directly connected to the CEC-Adapter, but through an AV-Receiver (Denon AVR-X3300W). But this issue was also present with my previous AV-Receiver (Marants SR-5008). |
Maybe this is related: Whenever there is a noticable delay between me pressing the button and kodi performing the action, then there is a very high change that the next button press is wrongly recognized as a double press. This delay between pressing a button and kodi performing the action happens pretty frequently. Also, when I hold down a direction button on my remote (to scroll through a list), the scrolling speed is painfully slow and also very erratic, meaning that the menu items don't change the selection on a fixed interval. These three issues (double presses, slow scrolling and erratic scrolling) are the reason why I almost only control Kodi using my smartphone. |
I wonder why the reverted "double press removal"-code was even necessary in the first place. I can't imagine my TV to actually send multiple button presses over CEC when I press the button only once. No other CEC controlled devices (like the PlayStation 3 and 4) have this issue. I think the reverted "double press removal"-code was probably just a workaround for another bug that results in libcec (or the firmware of the adapter) recognizing multiple button presses where is actually only one. |
This is the patch against master that seemed to fix the problem for me, as per the aforementioned commit reversion:
|
Same here on 2017 Philips OLED - Kodi 16 works fine, double presses on Kodi 17 (tested on Pi3, s905, s912). |
So, will something be done about this? Seeing that this project didn't have a single commit in almost a year, I fear this issue will never be fixed. In any way, the fix is trivial, as just one commit needs to be reverted. The commit in question didn't even try to fix anything, so there is no risk to re-introduce other bugs. What is the blocker here? Do you need more data? Should I submit the reversion of the commit as a pull request? Also, I tried really hard to find out what @popcornmix meant by "skip double press removal. It is handled through other means", but to no success. I also wasn't able to contact him. |
So, after studying quite some source code, I am not too sure that libcec is really at fault here. It could actually an issue with Kodi, but I am not certain yet. Anyway, it looks like @popcornmix actually committed a fix/workaround to Kodi that should solve this issue for us: xbmc/xbmc@a4a87e9 By tuning these values, we should be able to get these damn double presses under control. Now we just need to wait for Kodi 18 for these settings to become available :) |
Already tried different mutations of these value without success. |
I have the same issue. No mutations of the 3 values seems to fix the problem... |
Just wanted to report back that the patch from @satmandu solved the issue for me on a Philips TV with libcec 4.0.4 under LibreELEC 9.2 on a Raspi2! |
Hi All! Sorry for noob question, but i have exactly the same problem with my pana viera and latest kodi. |
@pozsothereal For what it is worth, I'm not having these issues any more using current ubuntu and kodi installed from the Kodi Stable PPA (ppa:team-xbmc/ppa) with our Panasonic tv. |
Hi, thanks for prompt reply. Im running rpi4 w buster and kodi 17.4, and would like to control gpio pins with remote button press. Now im able to do this with rpi.gpio and xdotool via cec client, but when i press a button once always send double keypress, doesnt help when i just really try push it shortly:( |
@pozsothereal You can copy those patches to a file and then go to your libcec folder and run That should apply the patch. (Or something similar.) |
Note also that you're running an older version of kodi... and if this is a kodi issue you're running into, you would be better off running the current version, which is 18.5 or so... |
Ah, i just realized that cec build in Kodi -btw now im using 18.5 and problem still exist-. |
You might want to ask on the kodi forums about this. They'll be more familiar with supporting custom kodi installs. |
I've got the same issue with a Panasonic TX-P42G30 in combination with a RPi 4 using LibreELEC 10.0 RC1 (Kodi 19.1). @popcornmix even though it's been quite some time, can you explain the need for the change? Are the "other means" of popcornmix@ef8bc8e the three added Kodi remote parameters? If yes, to what should they be set to achieve the same? |
Hello,
I use since 3 years pulse eight to command kodi (kodibuntu, based on ubuntu 14.04 and Isengard), via hdmi-cec, with my Logitech Harmony 350 Control without problem.
I upgrade successfully to Jarvis last year, no problem with hdmi-cec.
But I upgrade to Krypton last week (and upgrade to ubuntu 16.04 because vaapi/vdapu), and now my harmony repeated some inputs : no systematically, but alway, maybe 1 per 5 or 6 inputs.
for example (look just before thumbs-up)
https://drive.google.com/file/d/0B2zHcuM...sp=sharing
I tested on ubuntu 16.04, 16.10 and with librelec (last edition with krypton), with estuary skin and mimic, and I tried some manipulation :
osmc/osmc#174
or
https://gitlab.com/ember-dev/kodi/commit...24a65f1632
I try with the TV's remote control : same bug
I try with my phone (which have IR blaster) : no bug !
My TV is panasonic TX-P42V20E.
but without success.
The text was updated successfully, but these errors were encountered: