Fix the Optional type server status version being compared to null #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
granny
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server status version (
MinecraftServer.getServer().getStatus().version()) used to be a nullable class field, but it is now an Optional record field. Therefore, the comparison to null should be replaced withisEmpty(). In its current state, with the null check, this patch does nothing anymore (because the version will never be null).To verify the status will in fact be an empty Optional, see
net.minecraft.network.protocol.status#CODEC, which usesoptionalFieldOf, which returns acom.mojang.serialization.codecs.OptionalFieldCodecfor which thedecodemethod never returns null, but an empty Optional in the corresponding scenarios instead.