Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorder spark loader logic to fix a few issues #1326

Merged
merged 2 commits into from
May 15, 2023
Merged

reorder spark loader logic to fix a few issues #1326

merged 2 commits into from
May 15, 2023

Conversation

BillyGalbreath
Copy link
Contributor

Fixes multiple issues, including possibly #1324

YouHaveTrouble
YouHaveTrouble approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@YouHaveTrouble YouHaveTrouble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, didn't test.

@granny granny merged commit b842229 into PurpurMC:ver/1.19.4 May 15, 2023
@granny granny linked an issue May 15, 2023 that may be closed by this pull request
Purpur doesn't use spark in cache if download fails on startup. #1324
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YouHaveTrouble YouHaveTrouble YouHaveTrouble approved these changes

@encode42 encode42 encode42 approved these changes

@granny granny granny approved these changes

@SageSphinx63920 SageSphinx63920 SageSphinx63920 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Purpur doesn't use spark in cache if download fails on startup.
5 participants
@BillyGalbreath @YouHaveTrouble @encode42 @granny @SageSphinx63920