Add configuration option to replace incompatible enchantments #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
granny
approved these changes
Aug 23, 2023
granny
added
the
needs-docs
|
Merged into the unsafe enchants patch |
granny
removed
the
needs-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the behavior of incompatible enchantments in anvils is either to discard any enchantments that are incompatible, keeping the original enchantments (vanilla), or to allow both enchantments to exist (allow incompatible).
This pull request adds a third option: to replace the existing incompatible enchantments and to replace it with the applied enchantment at
settings.enchantment.anvil.replace-incompatible-enchantsFor example, an item with Sharpness and Unbreaking + an item with Smite and Fire Aspect will result in an item with Sharpness Unbreaking and Fire Aspect with vanilla behavior. With this configuration option, the output will instead be Smite + Unbreaking + Fire Aspect.