Skip to content

Commit

Permalink
Fixed issue displaying numbers in aggregated views #1498 [skip-ci]
Browse files Browse the repository at this point in the history
  • Loading branch information
Remi749 committed Apr 11, 2024
1 parent 5e9c6ce commit ad911bf
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Sjekk ut [release notes](./releasenotes/1.9.0.md) for høydepunkter og mer detal
- Rettet et problem hvor sorteringsindikatorene for kolonner i aggregerte oversikter ikke var riktig sjekket av [#1429](https://github.com/Puzzlepart/prosjektportalen365/issues/1429)
- Rettet et problem hvor mapper ikke ble provisjonert dersom det eksisterte mapper med samme navn i prosjektet [#1497](https://github.com/Puzzlepart/prosjektportalen365/issues/1497)
- Rettet et problem hvor tekstfeltet knyttet til `Fase` ikke ble riktig synkronisert til portefølje [#1492](https://github.com/Puzzlepart/prosjektportalen365/issues/1492)
- Rettet et problem med visning av tallverdier i aggregerte oversikter hvor det ble lagt på en stor mengde desimaler [#1498](https://github.com/Puzzlepart/prosjektportalen365/issues/1498)

### Forbedringer

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import strings from 'PortfolioWebPartsStrings'
import { tryParseInt } from 'pp365-shared-library'
import React from 'react'
import { ColumnRenderComponent } from '../types'

export const NumberColumn: ColumnRenderComponent = (props) => (
<span>{tryParseInt(props.columnValue, undefined)}</span>
)

NumberColumn.key = 'number'
NumberColumn.id = 'Number'
NumberColumn.displayName = strings.ColumnRenderOptionNumber
NumberColumn.iconName = 'NumberField'
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { useEffect } from 'react'
import { GetDataTypeProperties, IColumnDataTypeFieldOption } from './ColumnDataTypeField'
import { BooleanColumn } from './BooleanColumn'
import { CurrencyColumn } from './CurrencyColumn'
import { NumberColumn } from './NumberColumn'
import { DateColumn } from './DateColumn'
import { DialogColumn } from './DialogColumn'
import { FileNameColumn } from './FileNameColumn'
Expand Down Expand Up @@ -232,6 +233,7 @@ export function useColumnRenderComponentRegistry() {
DateColumn,
FileNameColumn,
CurrencyColumn,
NumberColumn,
ListColumn,
DialogColumn,
TagsColumn,
Expand All @@ -252,12 +254,6 @@ export function useColumnRenderComponentRegistry() {
strings.ColumnRenderOptionNote,
'EditStyle'
)
ColumnRenderComponentRegistry.registerColumnRenderOption(
'number',
'Number',
strings.ColumnRenderOptionNumber,
'NumberField'
)
ColumnRenderComponentRegistry.registerColumnRenderOption(
'percentage',
'Percentage',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ export type ColumnDataType =
| 'user'
| 'date'
| 'currency'
| 'number'
| 'tags'
| 'boolean'
| 'url'
Expand Down

0 comments on commit ad911bf

Please sign in to comment.