Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rettet et problem hvor taksonomifelt i redigeringspanel ikke støttet nivåer av termer #1507

Merged
merged 9 commits into from
Apr 24, 2024

Conversation

stigre
Copy link
Contributor

@stigre stigre commented Apr 23, 2024

Pull request (PR)

Sørg for at du ber om PR for din branch (høyre side). Sørg for at du gjør en PR mot riktig release-branch (venstre side). Sjekk commits og alle commit-meldingene.

Sjekklisten din

Alle sjekkpunktene under må være sjekket av og godkjent for at vi skal kunne merge branchen din mot dev.

  • Legg ved beskrivelse i CHANGELOG, markert med ID av issue knyttet til PR-en
  • Angi korrekt Milestone på PR-en og issuet, samt tilegn deg selv PR-en og legg til labels

Beskrivelse

Fikser et problem med at taksonomifelt i nytt redigeringspanel ikke støtter nivåer ved å introdusere komponenten ModernTaxonomyPicker. Denne komponenten tilbyr samme opplevelse som ut av boksen for taksonomifelt i SharePoint.

Picker i panelet:
image

Åpent panel med trevisning av termer:
image

Eksempel på term med undernivå:
image

image

Hvordan teste

# Handling Forventet resultat
1 Åpne et redigeringspanel som inneholder taksonomifelt. F.eks "Rediger prosjektinformasjon". Redigeringspanelet åpnes
2 Klikk på "Legg til et merke"-ikonet til høyre for feltet. Et panel med trevisning av termer åpnes
3 Klikk på merkene som skal legges til og deretter "Bruk" Panelet lukkes og merkene skal være fylt inn i feltet
4 Legg til term ved å søke rett i feltet Feltet skal gi forslag på treff i termene og la deg velge fra en liste
5 Lagre endringene Feltet som er endret skal oppdateres i prosjektet og porteføljen
6 Sjekk at termer er forhåndsvalgt i redigeringsfeltet dersom egenskapen har verdi fra før Tidligere lagrede verdier skal være forhåndsvalgt

Relevante issues (hvis aktuelt)

Sjekkliste for godkjenner

Alle sjekkpunktene under må være sjekket av og godkjent av reviewers for at vi skal kunne merge branchen din mot dev.

  • Sjekk at det er fylt ut testpunkter
  • Sjekk om det er nødvendig å nevne denne PR i release notes
  • Sjekk om det er nødvendig å oppdatere dokumentasjon for hjelpeinnhold

@Remi749 Remi749 self-requested a review April 23, 2024 12:00
@stigre stigre added this to the 1.9.1 milestone Apr 23, 2024
@stigre stigre added bug Something isn't working complexity: medium Issue/PR with medium complexity labels Apr 23, 2024
@stigre stigre self-assigned this Apr 23, 2024
@stigre stigre linked an issue Apr 23, 2024 that may be closed by this pull request
@tarjeieo
Copy link
Member

Kan vi også ta med et skjermbilde av et termset med flere nivåer?

@stigre
Copy link
Contributor Author

stigre commented Apr 24, 2024

Kan vi også ta med et skjermbilde av et termset med flere nivåer?

Har vi et eksempel hvor det ligger i panelet? Jeg fant ikke

@Remi749
Copy link
Collaborator

Remi749 commented Apr 24, 2024

Kan vi også ta med et skjermbilde av et termset med flere nivåer?

Har vi et eksempel hvor det ligger i panelet? Jeg fant ikke

Du må bare opprette noen undertermer for å teste og ta skjermbilde

@stigre
Copy link
Contributor Author

stigre commented Apr 24, 2024

ModernTaxonomyPicker har en visuel bug i single select modus, hvor forrige valg ikke avmarkeres om du velger et nytt. Denne feilen virker til å skje kun første gang før en term er lagret, men forsvinner etter et lagret valg lastes inn som initiell verdi.

pnp/sp-dev-fx-controls-react#1765

Gronn.horisont_.baerekraftig.utdanning.og.handling.for.fremtiden.Hjem.-.Google.Chrome.2024-04-24.10-34-22.mp4

@stigre stigre marked this pull request as ready for review April 24, 2024 10:52
@Remi749 Remi749 removed request for okms and olemp April 24, 2024 10:53
@stigre stigre requested a review from Remi749 April 24, 2024 10:53
Copy link
Collaborator

@Remi749 Remi749 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Remi749 Remi749 merged commit 5ac9f01 into releases/1.9 Apr 24, 2024
1 of 2 checks passed
@Remi749 Remi749 deleted the issue/1504 branch April 24, 2024 12:40
Remi749 added a commit that referenced this pull request May 3, 2024
* Fix issues with FluentProvider - Footer

* Use IdPrefixProvider for Fluent component, apply to WebPartTitle component + cleanup

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Build-Release.ps1: Checking potential issues with npm run generate-site-scripts

* Reverted manifest ID for footer (was changed in PR #1290)

* Hand error loading page when no report existed ++

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Bruk av UserMessage gjennom hele løsningen (#1293)

* Update UserMessage and FieldContainer component

* ColumnSearchPropertyField UserMessage adjustments

* Update UserMessages in PortfolioWebParts

* Use UserMessage instead of Alert and MessageBar (PortfolioWebParts

* ProgramWebParts

* shared-library

* ProjectInformation

* ProjectExtensions

* Use message consistency throughout solution

* Minor fix

* Another minor fix

* Redesign av Programadministrasjon (#1294)

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Refaktorering av FilterPanel (#1296)

* Visuelt løft på Hjelpeinnhold (#1295)

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fiks for #998 (#1297)

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Visulet løft - Programadministrasjon (#1298)

* PortfolioWebParts

* ProjectWebParts

* shared-library

* Linting....

* footer quickfix for program (helpContent)

* Fix for 4.2 #1267

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Visuelt løft - Filterpanel (#1299)

* Visual overhaul - FilterPanel

* Minor change

* Use Icon component from shared

* Fix for 3.14 #1267

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fiks for #1310

* ProjectSetup._isProjectSetup() now checks if WelcomePage equals 'SitePages/ProjectHome.aspx'

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Adjusted ProjectSetup._isProjectSetup() as some customers might have custom frontpage names

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* GtStatus*: High=>Medium=>Low

* Innføre nivå for Hjelpeinnhold (#1309)

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fix for #1312 (#1313)

* Oppdaterte lenke til Prosjektveiviseren (https://prosjektveiviseren.digdir.no) #1311 [skip-ci]

* Forbedringer tiltakshåndtering (#1317)

See #1315

* Fix for "Name cannot begin with the '&' character, hexadecimal value 0x26. Line 8, position 1143." [skip-ci]

* Program-feltnavn i programmer (#1314)

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fix for #1318

* Fix for #1341

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fix for #1339 [skip-ci]

* Update fluent ui packages and use new theme utility to match site themes

This fixes #1307

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Adjustment to lighter portion of fluent ui theme

* Add missing "Lenker" list with links

* Minor fix - GtLinkUrl

* Fix for #1322 og #1324 [skip-ci]

* Fix for #1336 [skip-ci]

* Fix for #1335 [skip-ci]

* Fix for #1320

* Fix for #1326, #1327 og #1325

* Fix for #1300

* Fix for #1331

* Fix for #1303

* Fix for #1333

* Fix issues with 'Datakilder' list

* Fix hardcoded url in Konfigurasjon page

* Fix for #1332

* Fix for #1308

* Fix for #1343

* Fix for #1305

* Fix locale for Program and Portfolio

* Prosjektforsiden blir nå vist når prosjektoppsett er ferdig (#1351)

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fiks for programtidslinje (#1352)

* Footer skal også vises for medlemmer (#1353)

* NoCrawl="true" for Prosjektdata (#1354)

* Fiks for GtRiskAction (#1357)

* Fix for #1363

* Update workflows

* Correct main channel component id's

* Fix for #1368

* Add title to links list so that UpdateBehavior skip works [skip-ci]

* Add missing string to ProgramWebParts [skip-ci]

* Aggregated list/fields changes cleanup

* Fix grammar for function comments [skip-ci]

* Minor cleanup [skip-ci]

* Translate dev guides to norgwegian + cleanup [skip-ci]

* Update Readmes

* Update README.md

* Update README.md

* Fix missing title in ProgramAdministration webpart

* Updated changelog with all new additions, improvements and fixes

* Update and init 1.9.0 release notes [skip-ci]

* Add smoketest issue template [test]

* Minor update to 1.9.0 releasenotes

* Fix problem with componentId for ideaProcessing

* Update releasenotes for 1.9.0 [skip-ci]

* Finish 1.9.0 visual overhaul release notes [skip-ci]

* Update all old photos from release notes + update footer section [skip-ci]

* Finish releasenotes for 1.9.0 [skip-ci]

* Add idea module related content to Projectportal configuration page

* Update version for shared package to 1.9.0.0 [test]

* CI [upgrade-all-sites-to-latest]

* Fix for #1390 [skip-ci]

* Add EnsureFooterExtension [upgrade-all-sites-to-latest]

* Disable various features for aggregated webpart [upgrade-all-sites-to-latest]

set as isParentProject

* Fix for #1416 [skip-ci]

* Fix issues with Program aggregated webparts for updating columns/views

* Add missing data source [skip-ci]

* Fix UpgradeAllSitesToLatest - aggregated webparts [skip-ci]

* Add missing locale strings for ProgramWebParts (aggregated overviews ++)

* Update scripts to ensure program aggregation webparts have the correct setup for 1.9.0 [skip-ci]

This had to be done due to deprecated data sources still in use

* Add additonal missing locale strings for ProgramWebParts + fixes to strings in PortfolioWebParts

* Even more locale strings missing from ProgramWebParts

* Another one...

* Update JsonTemplates for Program and Parent

* CI [test]

* Fix problems with Program/aggregated functionality for creating columns/views and changing order ++

* Linting...

* Move shared functions for Portfolio/Aggregating to shared PortalDataService [skip-install]

* Rework logic for adding columns to data sources

also fix bugs regarding creating/editing columns

* Fix problem with deleting columns from aggregated webparts + cleanup and improvements [skip-ci]

* Fix issues creating/deleting columns from Program aggregated lists

* Fix for issue where a published statusreport wasn't indicated as published top right [skip-ci]

* Fix issues with missing data i 'Økonomi' statussection #1419 #1380

* Fix for #1400

* Fix problems with creating columns in portfoliowebpart [skip-ci]

* Fix problem creating columns from PortfolioOverview webpart (Program) [skip-ci]

* Additional locale strings ++

* Fix problems with FluentProvider styling not working properly for all components

* Fix issue with PortfolioWebParts crashing [skip-ci]

* Fix RiskActionPlanner script when upgrading + various templates changes [skip-ci]

* Minor fix to smoketest issue template [skip-ci]

* Rework some of the functionality to deactivate ability to move hidden columns in EditViewColumnsPanel

Also add additonal aria's

* Always show uncategorized ProjectContentColumns for all aggregated categories

* Fix issues where users could change view while waiting for a newly changed view

* Fix for #1418 [skip-install]

* Properly hide 'SiteTitle' columns from project level aggregated views [skip-ci]

* Fix for #1443

* Fix for #1449

* Fix for #1397

* Fix for #1453

* Add message in FilterPanel if it is empty #1444

* Fix for #1403 [skip-ci]

* Actual fix for #1403

* Fix for #1393 [skip-ci]

* Fix for #1411 [skip-ci]

* Fix for #1384 [skip-ci]

* Partial fix for #1399 [skip-ci]

* Fix for #1424

* Fix issue with Project admin roles not working properly #1420

* Partial fix for #1454

* Adjustments to required fields and logic in EditPanels for PortfolioWebParts [skip-install]

* Remove mentions in changelog and releasenotes for #1225 as this doesn't work [skip-ci]

To be fixed/added in 1.9.0

* Fix for #1454

* Update build-release to include test channel build [skip-ci]

* Temporary disable of Add and Edit columns from overviews/aggregated webparts [skip-ci]

* Linting after merge [skip-ci]

* Fix for #1459

* Fix planner provision bug [test]

* Update CI to support packages-only build and upgrade [skip-ci]

* CI adjustments [skip-ci]

* CI test [packages-only]

* Rettet et problem hvor listedata tilhørende tidligere prosjektstatusrapporter ikke ble hentet inn (#1473) [packages-only]

* CI [packages-only]

* Grammar fix for cell with value "Svært alvorlig" [skip-ci]

* Update sp-js-provisioning to 1.2.2 #1479

* Small output change to UpgradeAllSitesToLatest script [skip-ci]

* Use "noPreview" for planner tasks migrated from risk actions #1480 [skip-ci]

* Fix issue where dynamic frontpage didn't work properly #1481

* Ability to turn on/off dynamic phase site page message when changing phase #1484

Added to webpart properties (showPhaseSitePageMessage)

* Fix problem with link not properly working for some child projects #1468

* Fix problem with "KUR" page URL setting when approving idea #1393 [packages-only]

* Fix issues with 'CreateParentProject' and 'ChildProjectAdmin' buttons #1412 [skip-ci]

* Add sum field to be used in #1485

* CI

* Summeringsfelt i prosjektstatusseksjon (#1486)

* Add sumField to SectionModel

* Minor adjustments

* Add summation to ListSection or UncertaintySection (addition/average)

* Fix problem with 'show all measurements' for benefits view (program) [skip-ci]

* Use SiteId when fetching timeline list items + minor fix #1477 [skip-ci]

* Fix displayName not being properly set from 'ProjectColumns' list #1458

* Fix for visibility of columns in 'show/hide' panel #1442 [skip-ci]

* Remove title property from ProgramAdministration #1376 [skip-ci]

* Fixed problem with sort indicators for aggregated views #1429 [skip-ci]

* Minor fix after fixing previous bug

* Add maxWidth values to all projectcolumns and projectcontentcolumns elements

* CI: Add templates for ideaconfig

* CI: Apply templates

* Prosjektutlisting forbedringer på ytelse og innlasting (#1493)

* Use react-window and AutoSizer to improve loading of projectList webpart

* Improve loading of project logos

* Minor adjustments

* Add missing package config

* Changelog

* Linting

* Fiks for #1478 (#1494)

* Legge til mulighet for konfigurere anbefalingsalternativer og verdier (#1495)

* Rework choices and recommendations to use values from field (JSON)

* Improve ideaRegistrartion code

* Improve ideaProcessing

* Improve ideaProjectData

* Minor fixes

* Final adjustments

* Changelog

* Add possiblity to add custom choice and recommendation

* Update changelog

* Linting

* Update pnpm-lock.yaml

* Add new field "GtActionComment" [skip-ci]

* Add 'GtActionComment' to templates and ProjectContentColumns list [skip-ci]

* Fix problem with folders not being provisioned properly if already existing #1497

* Fix issue where "GtProjectPhaseText" wasn't properly synced to hub #1492

* Remove sitescripts for idea

* Add removal off deprecated SiteScripts to PreInstallUpgrade script

* Fixed issue displaying numbers in aggregated views #1498 [skip-ci]

* Add Number field to custom edit panels #1496 [skip-ci]

* Fixed issue where published icon did not show up in projectstatus dropdown menu #1350

* Improvements to ProjectSetup error handling

* Fix issues with list commands for Idea lists #1430

* Tiny bugfix

* Fix issue where deprecated terms were shown in edit panels #1499

* Fix issue with numberOfLines not reflected in edit panel for multi-line fields #1500

* Fix issue with sorting of currency fields #1369

* Linting [skip-ci]

* Fix issue with exporting currency and number values in views #1395

* Fix issue with displaying currency values in edit panels #1503 [skip-install]

* Add templates to be used for #1490 [skip-install]

* Add PercentageColumn [skip-install]

* Finish 'resource allocation' for program/parent sites #1490

* Fixed issue where view-id wasn't added to url (PortfolioWebParts) #1355

* Fix issue with view not refreshing to a newly created view #1441 [skip-install]

* Forbedringer av Install.ps1 og UpgradeAllExistingSitesToLatest.ps1 skriptene (#1508)

* Fix for #1475 - target group sites

* Added progress bar putput #1487

* Added project properties list check

* More sensible handling of old resource field

* Better checking for handling deprecated wp

* WIP handling of #1487

* Better retrieval of installedversion and previousversion

* Better log handling and logging upgradeall-script #1487

* Meh logging

* changelog

* Fix for #1471

* Update CHANGELOG.md

---------

Co-authored-by: Bloom <remi.blom-ohlsen@puzzlepart.com>

* Rettet et problem hvor taksonomifelt i redigeringspanel ikke støttet nivåer av termer (#1507)

* Modern taxonomy picker as replacement for tagpicker

* Use dataAdapter context object - description as panel title - ITag -> ITermInfo in model

* Workaround to safely map ModernTaxonomyPicker initial values without affecting other components

* Linting and cleanup

* Changelog

* Initial value for single select taxonomy

* Update CHANGELOG.md

---------

Co-authored-by: Bloom <remi.blom-ohlsen@puzzlepart.com>

* Improvements to resource allocation

* Fix bug with projects not showing up in Timeline filterpanel

* Minor

* Add ProjectInformation to Projecttimeline filterpanel

* Final adjustments to filtering on timeline

* Linting

* Minor adjustment

* Fix problems with rush

* Add new filtering for ProgramWebParts

* Fix issue where projectinformation was not filterable for programs' timeline

* Rettet et problem hvor "Ansvarlig"-feltet i administrering av tiltak ikke viste personen som er valgt i feltet (#1509)

* Fixed responsible field not showing selected user on select

* Changelog

* Rettet et problem hvor det ikke var mulig å lagre tom verdi i valuta/tall felt fra redigeringspanel (#1512)

* Set null in case of falsy value in currency control

* Set null in case of falsy value for number field in edit panel

* Changelog

* Rettet et problem hvor lenke til prosjektets tidslinje ikke lenket riktig for program (#1513)

* Link to program timeline of project is program

* Changelog

* 1.9.1

* Update packages to version 1.9.1

* Update dependencies to 1.9.1

* Update information about 'Versioning' [skip-ci]

* Fix wrong dataType for 'Belastning' [skip-ci]

* Updated 'Fasesider' project extension for vertical section support #1521 [skip-ci]

* Fix for #1520 [skip-ci]

* Fix issue with 1/0 values in filterpanel not showing as 'Ja/Nei' #1522

* Fix issue where summation section was shown if summation was null #1515

* Fix issue with "Gå til idébehandling" not working #1516

* Title of a project is now synced to portfolio when synchronising project information #1518

* Actual fix for #1520 [ckip-ci]

* Fix for #1523

* Linting [skip-ci]

* Fix issue migrating risk actions #1524

* Update ProjecTemplates isDefaultTemplate overwrite

* Use Number icon for number fields

---------

Co-authored-by: github-automatic-chores <github-automatic-chores@users.noreply.github.com>
Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>
Co-authored-by: Tarjei E. Ormestøyl <ormestoyl@gmail.com>
Co-authored-by: Stian Grepperud <stian.grepperud@puzzlepart.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working complexity: medium Issue/PR with medium complexity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Støtte nivåer for taksonomi felter i nytt redigeringspanel
3 participants