Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the potential attributes of all exceptions explicit #1699

Merged
merged 1 commit into from
Jul 10, 2022
Merged

Make the potential attributes of all exceptions explicit #1699

merged 1 commit into from
Jul 10, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • Write a good description on what the PR does.

Description

Type of Changes

Type
✓ 🔨 Refactoring

Related Issue

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Jul 10, 2022
@DanielNoord DanielNoord added this to the 2.12.2 milestone Jul 10, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2644180827

  • 71 of 71 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 92.167%
Files with Coverage Reduction New Missed Lines %
astroid/exceptions.py 1 96.75%
Totals Coverage Status
Change from base Build 2643697273: 0.03%
Covered Lines: 9496
Relevant Lines: 10303
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. ✨ ! Should we backport to 2.12.2 though ?

@Pierre-Sassoulas
Copy link
Member

Sorry dumb question I did not see you set the milestone.

@DanielNoord DanielNoord merged commit 0079ead into pylint-dev:main Jul 10, 2022
@DanielNoord DanielNoord deleted the exceptions branch July 10, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
2.12.2
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas