Prevent applying boolean ops to NotImplemented
#1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
the
Maintenance
Pull Request Test Coverage Report for Build 2645011504
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Jul 10, 2022
| @@ -1117,6 +1117,12 @@ def __radd__(self, other): return NotImplemented | |||
| first = next(ast_node.infer()) | |||
| self.assertEqual(first, util.Uninferable) | |||
|
|
|||
| @pytest.mark.filterwarnings("error::DeprecationWarning") | |||
There was a problem hiding this comment.
Do we need to filter that ? I thought the fix was precisely to remove the deprecation warning ?
There was a problem hiding this comment.
Good Q, "filter" is a little misleading here. It's taking DeprecationWarning and raising it to error. Revert the fix and this test will fail.
There was a problem hiding this comment.
Otherwise the test would pass anyway, since pytest doesn't fail tests when there are deprecationwarnings.
There was a problem hiding this comment.
We might as well change the global configuration, we often have to so "fix deprecation warning" merge request both for astroid and pylint.
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jul 12, 2022
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
Prevents this DeprecationWarning:
DeprecationWarning: NotImplemented should not be used in a boolean contextReproducer:
python -Werror -m pylint ipaddressType of Changes