[teyit] Add teyit to the pre-commit hooks #1703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
Maintenance
| @@ -4543,7 +4543,7 @@ def test_lambda(self) -> None: | |||
| ) | |||
| inferred = next(node.infer()) | |||
| self.assertIsInstance(inferred, nodes.Const) | |||
| self.assertIs(inferred.value, False) | |||
| self.assertFalse(inferred.value) | |||
There was a problem hiding this comment.
This one feels wrong because we already check with a specialized function and inferred.value could be falsey.
There was a problem hiding this comment.
Yeah, this is incorrect, see: https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertFalse.
Makes me wonder whether we should really use this.
I have looked into https://github.com/dannysepler/pytestify and similar tools but thought it wasn't worth the churn to apply them.
There was a problem hiding this comment.
Migrating to pytest's assertions actually make more sense.
Pull Request Test Coverage Report for Build 2647322599
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
Type of Changes
Related Issue
We have a lot of non-pytest legacy test class in astroid so teyit feels appropriate.