Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch RecursionError in raise_if_nothing_inferred #1705

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Catch RecursionError in raise_if_nothing_inferred #1705

merged 2 commits into from
Jul 11, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Closes #1646

Refs #1660

Type of Changes

Type
✓ 🐛 Bug fix

@DanielNoord DanielNoord added this to the 2.12.2 milestone Jul 11, 2022
@DanielNoord
Copy link
Collaborator Author

Simple test with mock seemed much more robust 😄

@coveralls
Copy link

coveralls commented Jul 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2649679015

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 92.19%
Totals Coverage Status
Change from base Build 2645100812: 0.002%
Covered Lines: 9502
Relevant Lines: 10307
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test !

@Pierre-Sassoulas Pierre-Sassoulas merged commit bb4b66a into pylint-dev:main Jul 11, 2022
@jacobtylerwalls jacobtylerwalls removed their request for review July 11, 2022 15:18
Pierre-Sassoulas pushed a commit that referenced this pull request Jul 12, 2022
@DanielNoord @Pierre-Sassoulas
Catch RecursionError in raise_if_nothing_inferred (#1705)
9b7c2bc
Pierre-Sassoulas pushed a commit that referenced this pull request Jul 12, 2022
@DanielNoord @Pierre-Sassoulas
Catch RecursionError in raise_if_nothing_inferred (#1705)
5fa001f
@jacobtylerwalls jacobtylerwalls mentioned this pull request Aug 23, 2022
Closed
@DanielNoord DanielNoord deleted the recursion branch June 6, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Crash 💥
Projects
None yet
Milestone
2.12.2
Development

Successfully merging this pull request may close these issues.

Infinite loop when inferring from token import *
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas