Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some implicit typing #1706

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Add some implicit typing #1706

merged 3 commits into from
Jul 11, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • Write a good description on what the PR does.

Description

@Pierre-Sassoulas Please back port this so we can "use" it on pylint. It's related to two TODOs there.

Type of Changes

Type
✓ 🔨 Refactoring

Related Issue

@DanielNoord DanielNoord added Needs backport Maintenance Discussion or action around maintaining astroid or the dev workflow labels Jul 11, 2022
@DanielNoord DanielNoord added this to the 2.12.2 milestone Jul 11, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2649828667

  • 36 of 36 (100.0%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 92.371%
Files with Coverage Reduction New Missed Lines %
astroid/nodes/node_classes.py 3 95.69%
Totals Coverage Status
Change from base Build 2649733342: 0.007%
Covered Lines: 9711
Relevant Lines: 10513
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

@Pierre-Sassoulas Pierre-Sassoulas merged commit c942582 into pylint-dev:main Jul 11, 2022
@DanielNoord DanielNoord deleted the pytype branch July 11, 2022 14:35
Pierre-Sassoulas pushed a commit that referenced this pull request Jul 12, 2022
@DanielNoord @Pierre-Sassoulas
Add some implicit typing (#1706)
a4fd29e 
* Type most defintions of ``pytype`` and ``qname``

* Add typing to ``implicit_parameters``

* Type ``type()``
Pierre-Sassoulas pushed a commit that referenced this pull request Jul 12, 2022
@DanielNoord @Pierre-Sassoulas
Add some implicit typing (#1706)
162f8ed 
* Type most defintions of ``pytype`` and ``qname``

* Add typing to ``implicit_parameters``

* Type ``type()``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
2.12.2
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas