Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #1726

Merged
merged 4 commits into from
Aug 8, 2022

Conversation

updates:
- [github.com/asottile/pyupgrade: v2.37.2 → v2.37.3](asottile/pyupgrade@v2.37.2...v2.37.3)
- https://github.com/Pierre-Sassoulas/black-disable-checker/: v1.1.0 → v1.1.1
- [github.com/PyCQA/flake8: 4.0.1 → 5.0.3](PyCQA/flake8@4.0.1...5.0.3)
@coveralls
Copy link

coveralls commented Aug 2, 2022

Pull Request Test Coverage Report for Build 2817777003

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.257%

Totals Coverage Status
Change from base Build 2776943930: 0.0%
Covered Lines: 9699
Relevant Lines: 10513

💛 - Coveralls

As there's a lot of the format and the latter is incompatible with black.
@Pierre-Sassoulas Pierre-Sassoulas added the dependency Related to dependencies of the project label Aug 2, 2022
It's opinionated see PyCQA/flake8-bugbear#2
and every current warning is a false positive.
@Pierre-Sassoulas
Copy link
Member

Regarding the last check disabled I'd like your review @DanielNoord. It was raising:

astroid/nodes/scoped_nodes/scoped_nodes.py:2876:13: B901 Using `yield` together with `return x`. Use native `async def` coroutines or put a `# noqa` comment on this line if this was intentional.
astroid/nodes/node_classes.py:94:9: B901 Using `yield` together with `return x`. Use native `async def` coroutines or put a `# noqa` comment on this line if this was intentional.
astroid/inference.py:267:5: B901 Using `yield` together with `return x`. Use native `async def` coroutines or put a `# noqa` comment on this line if this was intentional.
astroid/inference.py:361:5: B901 Using `yield` together with `return x`. Use native `async def` coroutines or put a `# noqa` comment on this line if this was intentional.
astroid/inference.py:409:13: B901 Using `yield` together with `return x`. Use native `async def` coroutines or put a `# noqa` comment on this line if this was intentional.
astroid/inference.py:481:9: B901 Using `yield` together with `return x`. Use native `async def` coroutines or put a `# noqa` comment on this line if this was intentional.
astroid/inference.py:607:5: B901 Using `yield` together with `return x`. Use native `async def` coroutines or put a `# noqa` comment on this line if this was intentional.
astroid/inference.py:1150:9: B901 Using `yield` together with `return x`. Use native `async def` coroutines or put a `# noqa` comment on this line if this was intentional.
astroid/protocols.py:297:9: B901 Using `yield` together with `return x`. Use native `async def` coroutines or put a `# noqa` comment on this line if this was intentional.
astroid/protocols.py:452:9: B901 Using `yield` together with `return x`. Use native `async def` coroutines or put a `# noqa` comment on this line if this was intentional.
astroid/protocols.py:530:5: B901 Using `yield` together with `return x`. Use native `async def` coroutines or put a `# noqa` comment on this line if this was intentional.
astroid/protocols.py:610:9: B901 Using `yield` together with `return x`. Use native `async def` coroutines or put a `# noqa` comment on this line if this was intentional.

See PyCQA/flake8-bugbear#2 and I think every current warning is a false positive because it's always going to be intentional for legacy code.

setup.cfg Outdated
@@ -25,7 +25,7 @@ include_trailing_comma = True
skip_glob = tests/testdata

[flake8]
extend-ignore = E203,E266,E501,C901,F401
extend-ignore = E203,E266,E501,C901,F401,W503,B950,B901
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these three messages?

And why does this bump suddenly raise B901? That PR you mention was merged in 2016?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's a breaking change from flake8 > 5 that change the default vs disabled message. The two other messages are line too long and line break before binary operator (I did not remember but it's in the commit message).

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DanielNoord !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 09e5ce9 into main Aug 8, 2022
@DanielNoord DanielNoord deleted the pre-commit-ci-update-config branch August 8, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Related to dependencies of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants