-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit.ci] pre-commit autoupdate #1726
Conversation
updates: - [github.com/asottile/pyupgrade: v2.37.2 → v2.37.3](asottile/pyupgrade@v2.37.2...v2.37.3) - https://github.com/Pierre-Sassoulas/black-disable-checker/: v1.1.0 → v1.1.1 - [github.com/PyCQA/flake8: 4.0.1 → 5.0.3](PyCQA/flake8@4.0.1...5.0.3)
Pull Request Test Coverage Report for Build 2817777003
💛 - Coveralls |
As there's a lot of the format and the latter is incompatible with black.
It's opinionated see PyCQA/flake8-bugbear#2 and every current warning is a false positive.
Regarding the last check disabled I'd like your review @DanielNoord. It was raising:
See PyCQA/flake8-bugbear#2 and I think every current warning is a false positive because it's always going to be intentional for legacy code. |
setup.cfg
Outdated
@@ -25,7 +25,7 @@ include_trailing_comma = True | |||
skip_glob = tests/testdata | |||
|
|||
[flake8] | |||
extend-ignore = E203,E266,E501,C901,F401 | |||
extend-ignore = E203,E266,E501,C901,F401,W503,B950,B901 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these three messages?
And why does this bump suddenly raise B901
? That PR you mention was merged in 2016?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's a breaking change from flake8 > 5 that change the default vs disabled message. The two other messages are line too long and line break before binary operator (I did not remember but it's in the commit message).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @DanielNoord !
updates: