Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wrapt to 1.14 #1745

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Bump wrapt to 1.14 #1745

merged 4 commits into from
Aug 22, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Ref. #1516 (comment).

Type of Changes

Type
🐛 Bug fix

Related Issue

@DanielNoord DanielNoord added Needs backport dependency Related to dependencies of the project labels Aug 21, 2022
@DanielNoord DanielNoord added this to the 2.12.3 milestone Aug 21, 2022
@coveralls
Copy link

coveralls commented Aug 21, 2022

Pull Request Test Coverage Report for Build 2904545100

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.261%

Totals Coverage Status
Change from base Build 2903734675: 0.0%
Covered Lines: 9704
Relevant Lines: 10518

💛 - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should differentiate between Python 3.11 and other interpreters. We are compatible with wrap lower than 1.14 after all, let's not create dependency issues fort user if we can easily avoid them.

@DanielNoord
Copy link
Collaborator Author

But 1.14 supports 3.5+? Wouldn't we unnecessarily complicate our own dependency for gains that we do not know about?

@Pierre-Sassoulas
Copy link
Member

But 1.14 supports 3.5+?

The issue is not the version of the interpreter but the version required by all the other libs that can be installed by someone wanting to use pylint. There's probably a dependency on pypi or in an internal pypi repository somewhere that ask for wrapt < 1.14 (maybe for good reason, maybe without good reason but...). pylint/astroid would be impossible to install alongside it.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks bad, but I don't know what I did wrong.

pyproject.toml Outdated Show resolved Hide resolved
DanielNoord and others added 2 commits August 22, 2022 15:15
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
ChangeLog Outdated Show resolved Hide resolved
@DanielNoord DanielNoord merged commit ea26a15 into pylint-dev:main Aug 22, 2022
@DanielNoord DanielNoord deleted the wrapt branch August 22, 2022 17:25
DanielNoord added a commit to DanielNoord/astroid that referenced this pull request Aug 23, 2022
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
DanielNoord added a commit that referenced this pull request Aug 23, 2022
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Related to dependencies of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants