Use WeakKeyDictionary
in decorators.cached
#1781
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
Refs. #1780
@matusvalo would you be able to this change?
Type of Changes
Details
I use the following script to check for the leakage of
NodeNG
objects.On
main
this returns:On this
PR
this returns:We're definitely still leaking, but it seems to be better at least.
I ran the
pylint
test suite and the time was around as I expect and similar to a run againstmain
just before it. So I think the caching is also still working.