-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression in the creation of the __init__
of dataclasses
#1812
Conversation
Pull Request Test Coverage Report for Build 3176405357
💛 - Coveralls |
I expected the coverage to be |
I'm way over my head with this MR, I'm going to pass unless there's really no other reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an initial skim.
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
__init__
of dataclassess
__init__
of dataclasses
params_string += "*, " + prev_kw_only + ", " | ||
params_string += "*, " + prev_kw_only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain this change? If it's harmless, then consider not making the change to reduce the diff. The elif/else branches below also have the same trailing separator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prev_kw_only
now takes care of this itself in the new helper function so there is not need to add it here anymore.
Edit: Let me know if you want me to change this. Otherwise I think this can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that explains it. Merge ho!
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Steps
Description
Closes pylint-dev/pylint#7434
Type of Changes