Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements #1860

Merged
merged 5 commits into from
Nov 4, 2022
Merged

CI improvements #1860

merged 5 commits into from
Nov 4, 2022

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Nov 2, 2022

Description

Similar changes to pylint-dev/pylint#7651

  • Remove restore-keys. Especially on Windows there are issues with reusing old cache entries and trying to install newer versions. Those are just skipped if the old one still satisfies the requirement. It's easy / fast enough to create a whole new environment if something changes.
  • Add check-latest: true for setup-python action. This will prevent cache restore issue when runners use different Python patch versions. https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#check-latest-version
  • Add KEY_PREFIX env variable to more easily identify the key prefix in each workflow.
  • Replace setup.cfg with pyproject.toml for file hash

@cdce8p cdce8p added Needs backport Maintenance Discussion or action around maintaining astroid or the dev workflow labels Nov 2, 2022
@cdce8p cdce8p added this to the 2.12.13 milestone Nov 2, 2022
@coveralls
Copy link

coveralls commented Nov 2, 2022

Pull Request Test Coverage Report for Build 3378006405

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.272%

Totals Coverage Status
Change from base Build 3367353146: 0.0%
Covered Lines: 9862
Relevant Lines: 10688

💛 - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to trust you on this one, I'm not an expert. The new hash key does make much more sense than manually upgrading the cache indeed. I wonder why I did not think of this when upgrading astroid in pylint,

@Pierre-Sassoulas Pierre-Sassoulas merged commit b8691c4 into pylint-dev:main Nov 4, 2022
@cdce8p cdce8p deleted the ci-improvements branch November 4, 2022 10:05
@cdce8p
Copy link
Member Author

cdce8p commented Nov 4, 2022

The new hash key does make much more sense than manually upgrading the cache indeed. I wonder why I did not think of this when upgrading astroid in pylint,

You might want to take a look at pylint-dev/pylint#7651 then. It does simplify update astroid in pylint. The primer test failure there is expected.

Pierre-Sassoulas pushed a commit that referenced this pull request Nov 19, 2022
* Add check-latest to setup-python
* Use pyproject.toml for hash
Pierre-Sassoulas pushed a commit that referenced this pull request Nov 19, 2022
* Add check-latest to setup-python
* Use pyproject.toml for hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants