-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pytest 3 compatibility in brain_pytest #357
Conversation
|
||
try: | ||
import _pytest.freeze_support | ||
freeze_includes = _pytest.freeze_support.freeze_includes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to do the assignments here instead of in an else:
as there's no way this second line could raise an ImportError
, and this makes the nested ImportError
s much more readable IMHO.
Do I need to add myself to the copyrights, or will you run copyrite before the next release? |
1 similar comment
I can run it before the next release, you don't have to worried about that. Do you need a patch release or something? Since the default will go into 1.5.0, it could potentially take a while to be released, together with pylint 2.0, which is why I am asking. |
I think that would be great to have - I already have some suppressions for a I'm not sure what happens after upgrading to pytest 3.0 - the old code snippet would probably raise an |
This change adjusts brain_pytest for pytest 3, while also reintroducing pytest 2 compatibility.
This change adjusts brain_pytest for pytest 3, while also reintroducing pytest 2 compatibility.
This adds compatibility with pytest 3.0 to
brain_pytest.py
, where some attributes were added and others moved.It also adds some failing attributes which are already present in older pytest versions, like
pytest.xfail
which existed for a long time.In the second commit, I also re-added pytest 2.9 support (and it also seems to work fine with 2.7 still, didn't test older versions) as 3.0 is quite a big update and I don't expect everyone to upgrade immediately.